Skip to content
This repository has been archived by the owner on Dec 6, 2022. It is now read-only.

update: pull in upstream csb features #45

Merged
merged 1 commit into from
Apr 11, 2022
Merged

update: pull in upstream csb features #45

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM cfplatformeng/csb:0.5.1 as upstream
FROM cfplatformeng/csb:v0.10.0 as upstream

FROM alpine/k8s:1.20.7

Expand All @@ -9,6 +9,10 @@ RUN apk upgrade
# Install git so we can use it to grab Terraform modules
RUN apk add --update git

# Enable re-templates of Terraform Code
# Reference: https://github.com/GSA/data.gov/issues/3083
ENV BROKERPAK_UPDATES_ENABLED true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Env vars related to how it gets configured should probably happen on the docker compose side, but since this is presumably going to come out from behind the feature-flag I'm OK with doing it here, so that for the consumers of the image, it's as if that already happened.

HOWEVER, remember that the production SSB deployment doesn't use this image, so we need to also set it up in the app deployments.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point. I thought it was going to be a requirement for our operations for the foreseeable future, so it aligned with our other GSA customizations. But I agree that this is not a catch-all for our apps (unfortunately).


ENV PORT 8080
EXPOSE 8080/tcp

Expand Down