Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace all references and skip errors #70

Closed
wants to merge 1 commit into from
Closed

Conversation

avdata99
Copy link

Related to datagov-deploy#1895

This PR:

  • Replace all references to the new domain
  • Temporarily skip the error related whit this change

Copy link

@adborden adborden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@avdata99 this is a bit too heavy handed. I'm hoping we can use a local schema to validate against in a way that's independent of r.d.g and p.c.g. Let's sync up tomorrow.

"@context": "https://project-open-data.cio.gov/v1.1/schema/catalog.jsonld",
"describedBy": "https://resources.data.gov/schemas/dcat-us/v1.1/schema/catalog.json",
"conformsTo": "https://resources.data.gov/schemas/dcat-us/v1.1/schema",
"@context": "https://resources.data.gov/schemas/dcat-us/v1.1/schema/catalog.jsonld",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget that the data.json files we consume from agencies are still going to have the old https://project-open-data.cio.gov/v1.1/schema identifier, so we want to make sure our test fixtures reflect that. I don't think we should be editing any of these test samples.

if dataset.get("license") == "https://project-open-data.cio.gov/unknown-license":
dataset["license"] = "https://github.com/project-open-data/project-open-data.github.io/blob/master/unknown-license.md"
elif dataset.get("license") == "https://project-open-data.cio.gov/open-licenses":
dataset["license"] = "https://resources.data.gov/open-licenses/"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know this is meant as a temporary fix but I really want to avoid this. I'm afraid if we modify the third-party metadata like this, we find ourselves on a slippery slope. By modifying the agency's metadata, we're sort of tampering with it, diminishing it's authenticity.

As open data stewards, we want to maintain the authenticity and integrity in our chain of custody of data as much as possible using reproducible and well-known methods.

@adborden
Copy link

Since project-open-data.cio.gov has been restored, there is no need for an immediate temporary fix.

@adborden adborden closed this Jul 23, 2020
@adborden adborden deleted the domain_redirect branch July 23, 2020 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants