Skip to content
This repository has been archived by the owner on May 6, 2024. It is now read-only.

801 remove single event dependecy #804

Merged
merged 8 commits into from
May 16, 2023

Conversation

scottqueen-bixal
Copy link
Contributor

@scottqueen-bixal scottqueen-bixal commented May 9, 2023

PR Summary

In may cases the application was relying on a configuration that set multi-life dependency state to toggle between the former work of a single life event application. This work removes those single life event state dependency as they are no longer needed.

Related Github Issue

Type of change

Please delete options that are not relevant.

  • Task
  • Bug fix
  • New feature
  • This change requires a documentation update

Detailed Testing steps

code review @gchi25

  • review code to ensure no used code is removed

integration review @nehemiah-abuga

  • ensure the application passes our e2e test plan from release v1.0.0

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

@github-actions
Copy link

github-actions bot commented May 9, 2023

Pa11y testing results ``` > [email protected] test:pa11y > pa11y http://localhost:3000/

Welcome to Pa11y

Running Pa11y on URL http://localhost:3000/

No issues found!

@scottqueen-bixal scottqueen-bixal added the V1 Maintenance Improvement Use this label when making improvements/changes to BEARS V1 label May 10, 2023
@scottqueen-bixal scottqueen-bixal self-assigned this May 10, 2023
@github-actions
Copy link

Pa11y testing results ``` > [email protected] test:pa11y > pa11y http://localhost:3000/

Welcome to Pa11y

Running Pa11y on URL http://localhost:3000/

No issues found!

@scottqueen-bixal scottqueen-bixal linked an issue May 10, 2023 that may be closed by this pull request
@scottqueen-bixal scottqueen-bixal marked this pull request as ready for review May 10, 2023 14:39
@scottqueen-bixal scottqueen-bixal requested a review from a team as a code owner May 10, 2023 14:39
Copy link
Contributor

@nehemiah-abuga nehemiah-abuga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Executed e2e tests and all passed. Approved

@github-actions
Copy link

Pa11y testing results ``` > [email protected] test:pa11y > pa11y http://localhost:3000/

Welcome to Pa11y

Running Pa11y on URL http://localhost:3000/

No issues found!

@github-actions
Copy link

Pa11y testing results ``` > [email protected] test:pa11y > pa11y http://localhost:3000/

Welcome to Pa11y

Running Pa11y on URL http://localhost:3000/

No issues found!

@scottqueen-bixal scottqueen-bixal merged commit 31e5c36 into main May 16, 2023
@scottqueen-bixal scottqueen-bixal deleted the 801-remove-single-event-dependecy branch May 16, 2023 13:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
V1 Maintenance Improvement Use this label when making improvements/changes to BEARS V1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove single event dependency
3 participants