Skip to content
This repository has been archived by the owner on May 6, 2024. It is now read-only.

#712 update sitemap #775

Merged
merged 10 commits into from
May 2, 2023
Merged

Conversation

gchi25
Copy link
Contributor

@gchi25 gchi25 commented May 2, 2023

PR Summary

Create production sitemap.

Related Github Issue

Type of change

  • Bug fix

Branch Name

712-update-sitemap

Testing environment

https://federalist-edd11e6f-8be2-4dc2-a85e-1782e0bcb08e.sites.pages.cloud.gov/preview/gsa/usagov-benefits-eligibility/712-update-sitemap

Detailed Testing steps

  1. navigate to https://federalist-edd11e6f-8be2-4dc2-a85e-1782e0bcb08e.sites.pages.cloud.gov/preview/gsa/usagov-benefits-eligibility/712-update-sitemap/sitemap.xml
  2. Review the sitemap.

we should expect the following paths to appear
'/',
'/es'
'/death-of-a-loved-one',
'/es/death-of-a-loved-one',
'/disability',
'/es/disability',
'/retirement',
'/es/retirement',

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings

@gchi25 gchi25 requested a review from a team as a code owner May 2, 2023 14:41
@gchi25 gchi25 self-assigned this May 2, 2023
@gchi25 gchi25 linked an issue May 2, 2023 that may be closed by this pull request
15 tasks
@scottqueen-bixal scottqueen-bixal self-assigned this May 2, 2023
@scottqueen-bixal
Copy link
Contributor

@gchi25 excluding the unwanted paths in our config seems to give us the result we want, can you confirm?

    exclude: [
      '**/agencies',
      '**/types'
    ],

@github-actions
Copy link

github-actions bot commented May 2, 2023

Pa11y testing results ``` > [email protected] test:pa11y > pa11y http://localhost:3000/

Welcome to Pa11y

Running Pa11y on URL http://localhost:3000/

No issues found!

@gchi25
Copy link
Contributor Author

gchi25 commented May 2, 2023

@gchi25 excluding the unwanted paths in our config seems to give us the result we want, can you confirm?

    exclude: [
      '**/agencies',
      '**/types'
    ],

Tested. The sitemap works well without agencies and types.

@github-actions
Copy link

github-actions bot commented May 2, 2023

Pa11y testing results ``` > [email protected] test:pa11y > pa11y http://localhost:3000/

Welcome to Pa11y

Running Pa11y on URL http://localhost:3000/

No issues found!

nuxt.config.js Outdated
sitemap: {
hostname: `${SITE_URLPREFIX}${SITE_PREFIX}`,
routes: getLifeEvents().map((le) => `/${le}`),
hostname: "https://benefits-tool-beta.usa.gov",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@github-actions
Copy link

github-actions bot commented May 2, 2023

Pa11y testing results ``` > [email protected] test:pa11y > pa11y http://localhost:3000/

Welcome to Pa11y

Running Pa11y on URL http://localhost:3000/

No issues found!

Copy link
Contributor

@nehemiah-abuga nehemiah-abuga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have verified this change and the sitemap looks good as per the routes. Different routes work as expected

@github-actions
Copy link

github-actions bot commented May 2, 2023

Pa11y testing results ``` > [email protected] test:pa11y > pa11y http://localhost:3000/

Welcome to Pa11y

Running Pa11y on URL http://localhost:3000/

No issues found!

@scottqueen-bixal scottqueen-bixal merged commit 39c5af8 into multi-life-event-2023 May 2, 2023
@scottqueen-bixal scottqueen-bixal deleted the 712-update-sitemap branch May 2, 2023 20:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix sitemap for links to various pages based on environment
3 participants