Skip to content
This repository has been archived by the owner on May 6, 2024. It is now read-only.

760 update tab order #771

Merged
merged 1 commit into from
May 2, 2023
Merged

Conversation

scottqueen-bixal
Copy link
Contributor

@scottqueen-bixal scottqueen-bixal commented May 1, 2023

PR Summary

update tab order to match parent site, usa.gov

Related Github Issue

Type of change

Please delete options that are not relevant.

  • Task
  • Bug fix
  • New feature
  • This change requires a documentation update

Branch Name

760-update-tab-order

Testing environment

Link to a Federalist URL or to be tested on local dev environment.

Detailed Testing steps

navigate to feature branch testing environment, start tabbing into the site elements

  • Tabbing order should go as follows
  1. Skip to main content
  2. banner
  3. language switcher
  4. logo
  5. phone number
  6. search input
  7. search submit
  8. main nav

etc...

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

@scottqueen-bixal scottqueen-bixal changed the base branch from main to multi-life-event-2023 May 1, 2023 19:19
@scottqueen-bixal scottqueen-bixal self-assigned this May 1, 2023
@scottqueen-bixal scottqueen-bixal added the bug Something isn't working label May 1, 2023
@scottqueen-bixal scottqueen-bixal linked an issue May 1, 2023 that may be closed by this pull request
@scottqueen-bixal scottqueen-bixal marked this pull request as ready for review May 1, 2023 19:22
@scottqueen-bixal scottqueen-bixal requested a review from a team as a code owner May 1, 2023 19:22
@github-actions
Copy link

github-actions bot commented May 1, 2023

Pa11y testing results ``` > [email protected] test:pa11y > pa11y http://localhost:3000/

Welcome to Pa11y

Running Pa11y on URL http://localhost:3000/

No issues found!

Copy link
Contributor

@nehemiah-abuga nehemiah-abuga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have verified the tab order in both forward and reverse, content of tabs, they are clickable.

761-tab-order

@gchi25
Copy link
Contributor

gchi25 commented May 2, 2023

Tested. Worked as expected.

@scottqueen-bixal scottqueen-bixal merged commit d0ef9db into multi-life-event-2023 May 2, 2023
@scottqueen-bixal scottqueen-bixal deleted the 760-update-tab-order branch May 2, 2023 15:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix tab order to match usa.gov
3 participants