Skip to content
This repository has been archived by the owner on May 6, 2024. It is now read-only.

[Refactor] new header menu should be a loop #684

Closed
danny-englander opened this issue Mar 2, 2023 · 2 comments
Closed

[Refactor] new header menu should be a loop #684

danny-englander opened this issue Mar 2, 2023 · 2 comments
Assignees
Labels

Comments

@danny-englander
Copy link
Contributor

danny-englander commented Mar 2, 2023

User Story

As a developer, I need to simplify the new header menu into a loop.

Description

In the multi-life event version of the application, the new header menu should be a loop and not individually hardcoded. Doing this will make the code:

  1. DRY (Do not repeat yourself)
  2. Shorter
  3. Easier to maintain

Here is the current code: main...579-nav-changes#diff-83e8a3432a09a97279997b583856e373eb1dda6f55f6e7a532b7541cc6a79b31R79-R123

Noting that we have already done this with the new footer menu, e.g. https://github.com/GSA/usagov-benefits-eligibility/blob/multi-life-event-2023/components/BetaUsaGovFooterNav.vue#L22-L33

Proposed Fix

Follow the data structure for the provided footer menu example and do the same for the header menu.

@danny-englander
Copy link
Contributor Author

danny-englander commented Mar 10, 2023

@nehemiah-abuga Ready for testing

  • Pull multi-life-event-2023 to your local
  • run npm i
  • Run npm run dev
  • Go to http://localhost:3000
  • Inspect the main navigation, li.usa-nav__primary-item
  • ensure that each id is unique, for example item-id-mnav-10
  • Now switch to spanish and follow the same steps above

@nehemiah-abuga
Copy link
Contributor

I have verified this change in local. It looks good

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants