Skip to content
This repository has been archived by the owner on May 6, 2024. It is now read-only.

Add the CrossSell component back in when all translations have been completed #652

Closed
danny-englander opened this issue Feb 8, 2023 · 3 comments · Fixed by #730
Closed
Assignees
Labels

Comments

@danny-englander
Copy link
Contributor

danny-englander commented Feb 8, 2023

Description

In the multi-life event / new beta.usa.gov wrapper version of the application, we will remove the CrossSell component per @erniedeeb until all translations have been done for retirement and disability.

User Story

As a developer, I need to add the CrossSell component back in once all translations for retirement and disability have been completed for the new beta.usa.gov wrapper / multi-life event version of the application.

Branches

with CrossSell: https://github.com/GSA/usagov-benefits-eligibility/tree/multi-life-event-2023-cross-sell
without CrossSell: https://github.com/GSA/usagov-benefits-eligibility/tree/multi-life-event-2023

@danny-englander danny-englander self-assigned this Feb 8, 2023
@danny-englander danny-englander changed the title Remove the the CrossSell component until all translations have been done Add the CrossSell component back in when all translations have been completed Feb 8, 2023
danny-englander added a commit that referenced this issue Feb 8, 2023
@r-bartlett-gsa
Copy link
Contributor

@danny-englander I might be misunderstanding the purpose of this ticket/issue, but I thought I'll mention it anyways :) If a single-life-event version is enabled, the cross selling banners already do not display. The cross selling banners display only if multi-life event version is enabled, which only should be done when Spanish content is uploaded; and at that point you can still control these banners for each individual life event via markdown files. Please let me know if this does not make sense, and I will be happy to discuss this.
cc: @erniedeeb

@danny-englander
Copy link
Contributor Author

danny-englander commented Feb 9, 2023

@r-bartlett-gsa I think there is a misunderstanding here. The point of this ticket is to have the beta.usa.gov wrapper implemented which was started by Frank in the multi-life event version, thus I have 2 branches based on that as per above. Let me know if you need further clarification or if I can help you understand this better. The two branches above will be the way forward as per discussions and the roadmap. Soon, we will have our new content person working on the translations, the two of which as per mentioned above in the issue summary.

@danny-englander
Copy link
Contributor Author

Also see 71995f2 for reference.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
Archived in project
4 participants