Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix egress proxy route bug #60

Merged
merged 2 commits into from
Dec 20, 2024
Merged

Fix egress proxy route bug #60

merged 2 commits into from
Dec 20, 2024

Conversation

rahearn
Copy link
Contributor

@rahearn rahearn commented Dec 20, 2024

🎫 Addresses issue: no issue

🛠 Summary of changes

  • validates that the default route name for the egress proxy starts with a letter
  • adds the optional ability to manually specify what the route hostname should be
  • updates some obsolete README content from the v2 transition

@rahearn rahearn requested review from a team December 20, 2024 16:30
@rahearn rahearn self-assigned this Dec 20, 2024
Copy link
Contributor

@pauldoomgov pauldoomgov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wish apps.internal was scoped to the org level, but alas... I think squishing and keeping the last 63 chars is the least bad option, and thanks for the test! LGTM!

@rahearn rahearn merged commit 5a5a603 into main Dec 20, 2024
21 checks passed
@rahearn rahearn deleted the fix-egress-proxy-route-bug branch December 20, 2024 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants