-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate provider from cloudfoundry-community to cloudfoundry #57
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Most of these are optional, but I think the service-plan indexing ones are important.
OK, turns out those were not important because |
Co-authored-by: Bret Mogilefsky <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚢🐿️
🎫 Addresses issue: #56
closes #56
🛠 Summary of changes
cloudfoundry_network_policy
cf_org_name
and changing fromcf_space_name
tocf_space_id
orcf_space
(entire space resource) to help terraform properly sequence creationcloudfoundry_service_plans
data so I switched to using more real provider in tests and less mocking, and usingoverride_resource
to prevent creating expensive infrastructureUPGRADING.md
file with tips, but I also think most apps will stick on the version they started with for the most part.📜 Testing Plan
While this is in draft, I used it in a new application to verify behavior, and attempt to update an existing app to generate content for the UPGRADING doc.
It's been used for both GSA-TTS/continuous-assessment-poc#66 and GSA-TTS/gitlab-runner-cloudgov#62