Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate provider from cloudfoundry-community to cloudfoundry #57

Merged
merged 19 commits into from
Dec 9, 2024

Conversation

rahearn
Copy link
Contributor

@rahearn rahearn commented Nov 21, 2024

🎫 Addresses issue: #56

closes #56

🛠 Summary of changes

  • updates all resources to use the new cloudfoundry/cloudfoundry provider except clamav and egress_proxy both still have references to the community provider to use cloudfoundry_network_policy
  • lots of breaking changes with input variables, getting rid of unneeded cf_org_name and changing from cf_space_name to cf_space_id or cf_space (entire space resource) to help terraform properly sequence creation
  • I had issues trying to mock out cloudfoundry_service_plans data so I switched to using more real provider in tests and less mocking, and using override_resource to prevent creating expensive infrastructure
  • There is not currently an upgrade path for apps using the existing v1.x modules. I plan on adding an UPGRADING.md file with tips, but I also think most apps will stick on the version they started with for the most part.

📜 Testing Plan

While this is in draft, I used it in a new application to verify behavior, and attempt to update an existing app to generate content for the UPGRADING doc.

It's been used for both GSA-TTS/continuous-assessment-poc#66 and GSA-TTS/gitlab-runner-cloudgov#62

@rahearn rahearn requested review from mogul, asteel-gsa and a team November 21, 2024 21:58
anna-m-gsa
anna-m-gsa previously approved these changes Nov 22, 2024
Copy link
Contributor

@mogul mogul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most of these are optional, but I think the service-plan indexing ones are important.

cg_space/main.tf Show resolved Hide resolved
cg_space/tests/creation.tftest.hcl Show resolved Hide resolved
clamav/variables.tf Outdated Show resolved Hide resolved
database/main.tf Outdated Show resolved Hide resolved
database/main.tf Show resolved Hide resolved
redis/main.tf Show resolved Hide resolved
s3/main.tf Outdated Show resolved Hide resolved
s3/main.tf Show resolved Hide resolved
s3/tests/creation.tftest.hcl Show resolved Hide resolved
README.md Show resolved Hide resolved
@mogul
Copy link
Contributor

mogul commented Nov 25, 2024

Most of these are optional, but I think the service-plan indexing ones are important.

OK, turns out those were not important because cloudfoundry_service_plans filters the results; I understand that now and resolved those.

egress_proxy/main.tf Outdated Show resolved Hide resolved
egress_proxy/outputs.tf Outdated Show resolved Hide resolved
mogul
mogul previously approved these changes Dec 2, 2024
@rahearn rahearn marked this pull request as ready for review December 3, 2024 16:34
@rahearn rahearn requested a review from anna-m-gsa December 3, 2024 16:34
@rahearn rahearn requested review from mogul and a team December 3, 2024 16:35
UPGRADING.md Outdated Show resolved Hide resolved
UPGRADING.md Outdated Show resolved Hide resolved
UPGRADING.md Outdated Show resolved Hide resolved
UPGRADING.md Show resolved Hide resolved
UPGRADING.md Outdated Show resolved Hide resolved
@rahearn rahearn requested a review from mogul December 5, 2024 13:59
Copy link
Contributor

@mogul mogul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢🐿️

@rahearn rahearn merged commit ff5d822 into main Dec 9, 2024
21 checks passed
@rahearn rahearn deleted the migrate-provider branch December 9, 2024 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update to new cloudfoundry provider
3 participants