feat: create phone number component tckt-363 #382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
November 12, 2024 17:28
…id submission data and pass previous value into React component tckt-363 Co-authored-by: Daniel Naab [email protected]
|
Terraform plan for tts-10x-atj-dev Plan: 0 to add, 2 to change, 0 to destroy.Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
!~ update in-place
Terraform will perform the following actions:
# cloudfoundry_app.tts-10x-atj-dev-server-doj_tts-10x-atj-dev-server-doj-app_380DB029 will be updated in-place
!~ resource "cloudfoundry_app" "tts-10x-atj-dev-server-doj_tts-10x-atj-dev-server-doj-app_380DB029" {
!~ docker_image = "ghcr.io/gsa-tts/forms/server-doj:5ee1c8c4bf9ab6ac1b6ea2f9b893fbb28bf2b6ea" -> "ghcr.io/gsa-tts/forms/server-doj:d46a64a284dd08e8be42fcda4a239c34592b2d60"
id = "8a9fc8b6-af5e-45a2-abb6-2c24ecbcdfaa"
name = "tts-10x-atj-dev-server-doj-app"
# (17 unchanged attributes hidden)
# (3 unchanged blocks hidden)
}
# cloudfoundry_app.tts-10x-atj-dev-server-kansas_tts-10x-atj-dev-server-kansas-app_337A9CF1 will be updated in-place
!~ resource "cloudfoundry_app" "tts-10x-atj-dev-server-kansas_tts-10x-atj-dev-server-kansas-app_337A9CF1" {
!~ docker_image = "ghcr.io/gsa-tts/forms/server-kansas:5ee1c8c4bf9ab6ac1b6ea2f9b893fbb28bf2b6ea" -> "ghcr.io/gsa-tts/forms/server-kansas:d46a64a284dd08e8be42fcda4a239c34592b2d60"
id = "e885e531-11b7-4906-9cc3-0ddf483868f5"
name = "tts-10x-atj-dev-server-kansas-app"
# (17 unchanged attributes hidden)
# (3 unchanged blocks hidden)
}
Plan: 0 to add, 2 to change, 0 to destroy.📝 Plan generated in Post Terraform plan to PR comment #422 |
kalasgarov
force-pushed
the
feature/363-phone-number-2
branch
from
2dd84f4 to
01d4038
Compare
danielnaab
requested changes
Nov 13, 2024
packages/design/src/Form/components/PhoneNumber/PhoneNumber.tsx
Outdated
Show resolved
Hide resolved
kalasgarov
force-pushed
the
feature/363-phone-number-2
branch
from
01d4038 to
04d452a
Compare
danielnaab
reviewed
Nov 15, 2024
| </span> | ||
| ) : null} | ||
| <input | ||
| className="usa-input" |
There was a problem hiding this comment.
This could also get an error class on it:
Suggested change
| className="usa-input" | |
| className={classNames('usa-input', { | |
| 'usa-input--error': error, | |
| })} |
danielnaab
approved these changes
Nov 15, 2024
kalasgarov
force-pushed
the
feature/363-phone-number-2
branch
from
468ba0d to
59d57b3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created Phone Number Pattern for Forms Users.
Created Phone Number Pattern Edit for Form Builders.
Added unit tests for Phone Number config file.