Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the ability to move question #274

Merged
merged 22 commits into from
Aug 20, 2024
Merged
Show file tree
Hide file tree
Changes from 10 commits
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
803b498
Part 1 of moving question to another page
natashapl Jul 13, 2024
aae11f6
Part 2 of moving question to another page
natashapl Jul 13, 2024
396256f
Merge branch 'main' into move-question-to-another-page
natashapl Jul 13, 2024
b8a7269
Added the ability to move question to another page
natashapl Jul 24, 2024
aab0886
Added the ability to move question to another page
natashapl Jul 24, 2024
1aeedbd
Merge branch 'main' into move-question-to-another-page
natashapl Jul 24, 2024
f343011
Merge branch 'main' into move-question-to-another-page
natashapl Jul 24, 2024
56fdff7
fixing get by role selector to remove ambiguity
ethangardner Jul 24, 2024
faf1b36
removed logging
ethangardner Jul 24, 2024
bca169d
Removed some console logs
natashapl Jul 24, 2024
02dfdef
Fixed some bugs and accessibility issues
natashapl Jul 26, 2024
594ec55
Fixed some bugs and accessibility issues part 2
natashapl Jul 26, 2024
12b016c
Addressed some bugs and feedback reviews
natashapl Jul 31, 2024
5066c38
Addressed some bugs and feedback reviews Part 2
natashapl Jul 31, 2024
acee9ad
Updated the builder test to account for source page
natashapl Jul 31, 2024
5f60cfe
Merge branch 'main' into move-question-to-another-page
natashapl Jul 31, 2024
964d36c
Made updates per the reviews in my PR
natashapl Aug 6, 2024
6e1766b
Made updates per the reviews in my PR Part 2
natashapl Aug 6, 2024
bcba4ba
Ensured that page types can't be moved
natashapl Aug 6, 2024
14dc6d0
A minor update to the store.ts
natashapl Aug 6, 2024
0cbf279
A minor update to the store.ts Part 2
natashapl Aug 6, 2024
f149ef6
Merge branch 'main' into move-question-to-another-page
natashapl Aug 17, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions apps/spotlight/src/env.d.ts
Original file line number Diff line number Diff line change
@@ -1 +1,2 @@
/// <reference path="../.astro/types.d.ts" />
/// <reference types="astro/client" />
2 changes: 1 addition & 1 deletion e2e/src/create.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ const createNewForm = async (page: Page) => {
}

const addQuestions = async (page: Page) => {
const menuButton = page.getByRole('button', { name: 'Question' });
const menuButton = page.getByRole('button', { name: 'Question', exact: true });
await menuButton.click();
await page.getByRole('button', { name: 'Short Answer' }).click();
await menuButton.click();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -282,12 +282,9 @@ const AddPatternDropdownContent = ({
className={`${styles.dropdownMenu} usa-list usa-list--unstyled position-absolute bg-white z-100 shadow-3 text-left`}
>
{availablePatterns.map(([patternType, pattern], index) => (
<li
key={index}
className={`${styles.dropdownItem} padding-1 cursor-pointer margin-left-1`}
>
<li key={index} className={`${styles.dropdownItem} margin-left-1`}>
<button
className="bg-transparent padding-0 border-0"
className="bg-transparent padding-1 text-left width-full cursor-pointer border-0"
onClick={() => {
patternSelected(patternType);
}}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ export const PreviewPattern: PatternComponent = function PreviewPattern(props) {
const EditComponent = context.editComponents[props.type];
return (
<div
id="editComponent"
natashapl marked this conversation as resolved.
Show resolved Hide resolved
ref={focusRef}
onClick={event => {
if (EditComponent && !isPatternEditControlEvent(event)) {
Expand Down
Loading
Loading