Limit external-dns to exactly one zone #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robert-bryson
previously approved these changes
Mar 2, 2022
To recognize aliases, use 'type -a'; Fix for #81; Reference: https://github.com/nickumia-reisys/github-action-test/runs/5386457012?check_suite_focus=true#step:2:11, Successful Run: https://github.com/nickumia-reisys/github-action-test/runs/5386457073?check_suite_focus=true#step:3:45
mogul
force-pushed
the
another-fix-for-finding-binaries
branch
from
b100e11 to
43dfd6f
Compare
mogul
changed the title
The Bitnami one we were using (probably based on an old blog post) gets an "F" security rating in artifacthub.io despite being maintained and regularly updated. The official one gets an "A".
mogul
force-pushed
the
another-fix-for-finding-binaries
branch
from
af3fe98 to
d96b883
Compare
|
(I don't know why this closed.) |
I didn't test this, but.. Reference 1: https://github.com/kubernetes-sigs/external-dns/blob/master/docs/tutorials/aws.md#manifest-for-clusters-without-rbac-enabled Reference 2: https://github.com/kubernetes-sigs/external-dns/blob/b1ccdfed773ca678b46bf2eb815cbed89b648cbf/charts/external-dns/README.md#configuration P.S. We might need to yamlencode it, but maybe not.. https://www.terraform.io/language/functions/yamlencode#examples
Again.. no guarantee it will work, but I feel like it's easier to run it on github actions than manually :/
Due to the upgrade in helm chart, the format of some arguments changed and weren't properly accounted for
We just need to set it to be the default.
|
OK, this is pretty much back to where it was, as far as GSA/data.gov#3706. All that remains is properly waiting for DNS to be resolvable before proceeding with tests. |
|
Fixed the DNS resolution waiting-loop in |
|
Now blocked waiting on 18F/dns#593 |
|
That was quick! Now just waiting on the test to pass. |
mogul
force-pushed
the
another-fix-for-finding-binaries
branch
from
8c01e16 to
e2e81e8
Compare
Also changes the suffix text to make it more obvious why it's there
We still leave a hint as to how people running tests manually can recover
|
Unless DNSSEC takes a long time to setup too based on DNS propagation, the test failed for no apparent reason.. Unless the dns server being requested to do dnssec validation was just a bad one 😕 |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See kubernetes-sigs/external-dns#422
This also ensures that
prerequisite_binaries_presentworks even if the binaries are available via aliases.