Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recompile dev-requirements.txt #4297

Merged
merged 1 commit into from
Sep 20, 2024
Merged

Recompile dev-requirements.txt #4297

merged 1 commit into from
Sep 20, 2024

Conversation

asteel-gsa
Copy link
Contributor

@asteel-gsa asteel-gsa commented Sep 20, 2024

Re-compiles the dev-requirements.txt file.

  • Pins tomli

Copy link
Contributor

github-actions bot commented Sep 20, 2024

Terraform plan for dev

Plan: 1 to add, 0 to change, 1 to destroy.
Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
-/+ destroy and then create replacement

Terraform will perform the following actions:

  # module.dev.module.cors.null_resource.cors_header must be replaced
-/+ resource "null_resource" "cors_header" {
!~      id       = "*******************" -> (known after apply)
!~      triggers = { # forces replacement
!~          "always_run" = "2024-09-20T17:27:29Z" -> (known after apply)
        }
    }

Plan: 1 to add, 0 to change, 1 to destroy.

Warning: Argument is deprecated

  with module.dev-backups-bucket.cloudfoundry_service_instance.bucket,
  on /tmp/terraform-data-dir/modules/dev-backups-bucket/s3/main.tf line 14, in resource "cloudfoundry_service_instance" "bucket":
  14:   recursive_delete = var.recursive_delete

Since CF API v3, recursive delete is always done on the cloudcontroller side.
This will be removed in future releases

(and 6 more similar warnings elsewhere)

❌ Plan not applied in Deploy to Development and Management Environment #809 (Plan has changed)

@asteel-gsa asteel-gsa marked this pull request as draft September 20, 2024 15:33
@asteel-gsa asteel-gsa marked this pull request as ready for review September 20, 2024 15:33
@asteel-gsa asteel-gsa force-pushed the recomplie-dev-requirements branch from 437f794 to 9be3cdb Compare September 20, 2024 15:37
Copy link
Contributor

github-actions bot commented Sep 20, 2024

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
18424 16782 91% 0% 🟢

New Files

No new covered files...

Modified Files

No covered modified files...

updated for commit: f293d2b by action🐍

@asteel-gsa asteel-gsa force-pushed the recomplie-dev-requirements branch from 9be3cdb to f293d2b Compare September 20, 2024 17:32
@GSA-TTS GSA-TTS deleted a comment from github-actions bot Sep 20, 2024
@asteel-gsa asteel-gsa changed the title Recompile dev-requirements.txt Recompile dev-requirements.txt [don't merge just yet] Sep 20, 2024
@asteel-gsa asteel-gsa closed this Sep 20, 2024
@asteel-gsa asteel-gsa reopened this Sep 20, 2024
Copy link
Contributor

github-actions bot commented Sep 20, 2024

Terraform plan for meta

No changes. Your infrastructure matches the configuration.
No changes. Your infrastructure matches the configuration.

Terraform has compared your real infrastructure against your configuration
and found no differences, so no changes are needed.

Warning: Argument is deprecated

  with module.s3-backups.cloudfoundry_service_instance.bucket,
  on /tmp/terraform-data-dir/modules/s3-backups/s3/main.tf line 14, in resource "cloudfoundry_service_instance" "bucket":
  14:   recursive_delete = var.recursive_delete

Since CF API v3, recursive delete is always done on the cloudcontroller side.
This will be removed in future releases

✅ Plan applied in Deploy to Development and Management Environment #809

@asteel-gsa asteel-gsa changed the title Recompile dev-requirements.txt [don't merge just yet] Recompile dev-requirements.txt Sep 20, 2024
@asteel-gsa asteel-gsa added this pull request to the merge queue Sep 20, 2024
Merged via the queue into main with commit 076d208 Sep 20, 2024
29 checks passed
@asteel-gsa asteel-gsa deleted the recomplie-dev-requirements branch September 20, 2024 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants