335 #1560
Open
335 #1560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 21 commits
December 7, 2020 13:50
Added testQuery Renamed compareSimulation to compareTimeseriesSimulation Renamed inputKeys2 to inputTimeIndex Compare Results Added expectedReverseMap check for compareExpectedWithSimulationOutput For compareExpectedAndSim added better process in for input with missing property, i.e. "hasMeasurementDifference"
…ut processing is finished
…ut the same as the input. A new TestConfig flag was added to disable comparing of missing simulation or timeseries output data since it creates so many mismatched comparisons.
…ut the same as the input. A new TestConfig flag was added to disable comparing of missing simulation or timeseries output data since it creates so many mismatched comparisons.
poorva1209
requested review from
singha42
and removed request for
poorva1209
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This includes fixes for issues discovered while testing the PYVVO application.
The TestManager now supports querying the timeseries data base in small time windows so the queries are not as time consuming.
Input commands that do not have a matching expected value are published as in the expected results output with the expected value being 'NA' the revers is true for actual values.
So we have these cases.
Time matches and the object MRID matches and the values match.
Time matches and the object MRID matches but the values do NOT match.
Time matches and the object MRID do not match but the values do NOT match since they do not exist.
Fixes #1287, #335
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
This has been tested with unit test and test in gridappsd-test repo.
Test Configuration:
Checklist: