Fix _TORCH_GREATER_EQUAL_1_12 with lightning_utilities #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dd it as it was originally done
✅ Deploy Preview for poutyne ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #174 +/- ##
=======================================
Coverage 94.20% 94.20%
=======================================
Files 46 46
Lines 3276 3277 +1
=======================================
+ Hits 3086 3087 +1
Misses 190 190 ☔ View full report in Codecov by Sentry. |
|
You probably didn't ran the formatting correctly. It should be alright the way it was. Can you revert the formatting changes and I will merge the PR? |
|
Allez hop cascade! Must have a setting in neovim that does some formatting. I simply reverted the file. |
freud14
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
torchmetricsno longer has_TORCH_GREATER_EQUAL_1_12. I simply added the initial implementation usinglightning_utilities.Even though
lightning_utilitiesis a requirement oftorchmetricsI figured we could make it explicit that we depend on that.Furthermore, it looks like some styling was not properly applied. As far as I can tell, all the formatting done is correct.