Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GPII-3202: Added extra language values as requested by Astea #640

Merged
merged 3 commits into from
Sep 26, 2018

Conversation

amb26
Copy link
Member

@amb26 amb26 commented Jul 30, 2018

No description provided.

@gpii-bot
Copy link

CI job passed: https://ci.gpii.net/job/universal-tests/1003/

@javihernandez
Copy link
Member

Hi @amb26,

FYI, for the feds-audit demo, I left the languages that the QSS only shows (https://github.com/GPII/universal/blob/feds-audit/testData/ontologies/flat.json5#L220). I did this because the PSP was taking these values for the language drop down list and was confusing to have a different list of languages in the two sides (PSP and QSS).
Shall we only have those that we are going to show in the QSS? Or will the QSS include all the languages listed in the language term we're about to update?

@amb26
Copy link
Member Author

amb26 commented Sep 19, 2018

@javihernandez - happy to update with material from feds_audit - @danailbd could you double-check that this is appropriate?

@gpii-bot
Copy link

CI job passed: https://ci.gpii.net/job/universal-tests/1125/

@danailbd
Copy link
Contributor

@amb26, yes, the current list looks perfect. Here's a ref with the list we use for the QSS.

Just to note, the only reason why the QSS keeps its own list of language choices is that it displays the different options with friendlier names. Currently the list contains both the "system known" value (e.g. en-US) and the displayed name (e.g. English).

@sgithens
Copy link
Member

@amb26 Is this ready to be merged?

@javihernandez javihernandez merged commit 056fc05 into GPII:master Sep 26, 2018
javihernandez added a commit that referenced this pull request Sep 26, 2018
* amb26/GPII-3202:
  GPII-3202: Updated language list following review
  GPII-3202: Added extra language values as requested by Astea
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants