Gpii 2452 Initial Suggestions and Review #1

sgithens · 2017-08-05T23:12:22Z

This is the first PR for this repo. I realize there is a lot of work and mess that needs cleanup, but a first round of suggestions, especially for fluid and framework related stuff is appreciated.

https://issues.gpii.net/browse/GPII-2452

…mation yet.

Temporarily including a local set of testData to ease development.

Committing default _settings.scss from Foundation 6.3.0 before making modifications.

- Removing markdown descriptions for now. - Changing "Add Pref Set" to "Add Context" - Removing context icons and earcons buttons since we don't have any yet. - Changed left hand product list to be <li>'s instead of <h4>'s

…lock

Factored left hand product list into a component and added a search filter to the top of it.

- Numerous changes based off of continuing prototyping, and the UI review of June.

- Removing half baked settings reference page

- Created utility routine for filtering an index - Updated usage in components - Added some unit tests for it

- Removing numerous console.log statements - Putting in a temporary fix for the add context dialog until it's refactored in to a proper component.

- Changed to Yes/No based on UI Review

- Renaming editprefset.js to editprefset-viewport.

- Setting up modelrelay from the main editPrefs component to the child product tables to save their search/filter settings in the event that page is rerendered, or we need to save all the settings.

…er needed

…fixes

sgithens · 2019-05-27T19:56:11Z

@cindyli @amb26 I believe I'll addressed most of the feedback, and that the repo is hopefully in fairly maintainable shape now. There are a few comments that suggested improved decoupling between some of the components, but I think they will require a bit more work, so I would like to make jira tickets for them and mark them post 1.0

I do need to make a release of this for the project timeline, so if you're comfortable with this, I would like to merge what is currently here into the proper GPII repo and tag it.

amb26 · 2019-05-27T20:15:07Z

src/js/client/editprefset-dialogs-widget.js

+    }
+});
+
+gpii.devpmt.dialogs.confirmRemoveProductDialog.acceptConfirmDialog = function (closeDialog, prefsSet, product, editProductEnabled) {


As in other cases this simple sequential listener should be dismantled into two successive namespaced listeners with priority

This is a little bit of an edge case, and I have comments about it in the grade it inherits from. For certain dialogs that require this ordering, because of the way the Foundation close works, closing the dialog will stop the rest of the listener chain.

src/js/client/editprefset-mineAllSwitch-widget.js

src/js/client/editprefset-viewport.js

amb26 · 2019-05-27T20:29:15Z

src/js/client/editprefset-viewport.js

+fluid.defaults("gpii.devpmt.editPrefs", {
+    gradeNames: ["gpii.devpmt.viewComponent"],
+    mergePolicy: {
+        allSolutions: "noexpand",


This is plenty wierd - how do values get into these options, and why mustn't they be expanded?

They are added by the gpii-handlebars helper tag that creates the component on the page template. They are listed as "noexpand", because some of the entries and syntax in them are interpreted as IoC references, variables, or other things during the component installation which tries to mangle them into something else.

Granted, there are a few other things that need to be included on a round of a ResourceLoader-isation, but I'd like to jira that and make it part of the next round of work.

src/js/client/helpers.js

src/templates/partials/common-includes.handlebars

sgithens · 2019-05-28T23:00:26Z

@amb26 I've either resolved or added some dialog on the most recent comments. Any chance I can merge this in to the GPII/gpii-devpmt repo at this point?

amb26 · 2019-05-29T12:36:02Z

Tests are currently hanging. I get a bunch of failed calls to "parse" as follows:

13:32:41.924:  Sending a POST request to: /ppt/dev/login on port 8085
13:32:41.928:  Ignoring call to invoker parse of component {
    "typeName": "kettle.dataSource.encoding.JSON5",
    "id": "1bp29b9s-762",
....
which has been destroyed

and then finally the sequence hang message

13:32:47.029:  Test case listener has not responded after 5000ms - at sequence pos 6 of 8 sequence element {
    "event": "{pptHomeRequest}.events.onComplete",
    "listener": "kettle.test.assertResponse",
    "args": {
        "message": "Checking for part of the html page",
        "string": "{arguments}.0",
        "request": "{pptHomeRequest}",
        "plainText": true,
        "expectedSubstring": "prefsSafe-alice"
    }
} of fixture Successfull login to PPT, and checking access to authorized page.

sgithens · 2019-06-10T13:33:52Z

I saw this as well and have fixed them up, and also added the note in the README on the current dependence on having a GPII-2966 universal running.

Tests are currently hanging. I get a bunch of failed calls to "parse" as follows:

13:32:41.924:  Sending a POST request to: /ppt/dev/login on port 8085
13:32:41.928:  Ignoring call to invoker parse of component {
    "typeName": "kettle.dataSource.encoding.JSON5",
    "id": "1bp29b9s-762",
....
which has been destroyed

and then finally the sequence hang message

13:32:47.029:  Test case listener has not responded after 5000ms - at sequence pos 6 of 8 sequence element {
    "event": "{pptHomeRequest}.events.onComplete",
    "listener": "kettle.test.assertResponse",
    "args": {
        "message": "Checking for part of the html page",
        "string": "{arguments}.0",
        "request": "{pptHomeRequest}",
        "plainText": true,
        "expectedSubstring": "prefsSafe-alice"
    }
} of fixture Successfull login to PPT, and checking access to authorized page.

sgithens · 2019-06-14T21:48:48Z

@amb26 Having fixed up the existing tests, I'd like to potentially merge and tag this on Monday if you're feeling comfortable with it for now.

amb26 · 2019-06-17T11:40:39Z

I tested this with an instance of the GPII-2966 universal running on the local machine, and got just the same failure as listed above. I did notice that the universal instance got a connection on the new /prefssafes endpoint as below, so at least something is going right:

12:38:30.826:  Invoking handler gpii.preferencesServer.prefsSafeList.handler for route /prefssafes with expectedGrade kettle.request.htt
12:38:30.844:  Kettle server allocated request object with type gpii.preferencesServer.prefsSafeList.handler
12:38:30.847:  DataSource Issuing HTTP request with options {
    "port": 25984,
    "method": "GET",
    "headers": {

    },
    "protocol": "http:",
    "auth": null,
    "host": "127.0.0.1",
    "hostname": "127.0.0.1",
    "path": "/gpii/_design/views/_view/listPrefsSafes",
    "termMap": {

    },
    "url": "http://localhost:25984/gpii/_design/views/_view/listPrefsSafes",
    "directModel": {

    },
    "operation": "get",
    "reverse": false,
    "writeMethod": "PUT",
    "notFoundIsEmpty": true
}

sgithens · 2019-06-20T03:19:35Z

@amb26 Hi! I just cloned a fresh copy of both these branches and was able to run the tests successfully, as well as start it up and use the webapp in a browser.

It looks above like maybe there is something wrong with the couch instance?

In order to start up the GPII-2966 universal branch I did:

#host machine
vagrant up
# in the fedora linux terminal
cd sync/universal
./scripts/vagrantCloudBasedContainers.sh

I then changed the Virtual Box port forwarding to send 9081 -> 8081

sgithens · 2019-06-23T02:31:14Z

@amb26 Ok, here are the exact steps I used to run this requiring zero docker or vagrant containers. (other than the fact that my local couchDB instance runs in a docker container, but any Couch available on 8081 should be fine). Obviously the remotes don't need to be renamed, but I wanted to paste the exact commands I used.

CouchDB running on port 8081, with an empty datastore, or at least no gpii database, however you like to do that.
Universal GPII-2452

git clone [email protected]:GPII/universal.git
cd universal/
git remote rename origin GPII
git checkout -b GPII-2966 GPII/GPII-2966
npm install
GPII_COUCHDB_URL="http://localhost:5984/gpii" GPII_APP_DIR=$(pwd) bash -c ./scripts/deleteAndLoadSnapsets.sh

export NODE_ENV=gpii.config.preferencesServer.standalone.production
npm start

PPT

git clone [email protected]:sgithens/gpii-devpmt.git
cd gpii-devpmt/
git remote rename origin sgithens
git checkout -b GPII-2452 sgithens/GPII-2452
npm install
npm test

amb26 · 2019-06-28T23:25:03Z

Cheers - the test coverage of this pull is extremely bad (25% branch coverage) but I am merging since I have now been able to verify the tests

sgithens added 30 commits February 10, 2017 17:30

Initial commit

6e68123

GPII-2298 Initial commit for DevPTT Milestone 1

445ac7c

GPII-2298 Writing documenation

1f4f83f

GPII-2298 Minor electron changes and README

7841ac4

GPII-2298 Removing static view in favor of the client side editable one

e77cc55

GPII-2289 Lots of work on basic first round of mockup implementation.

ec8d8bb

GPII-2289 Adding template for all settings page.

7ff82ed

GPII-2289 Adding quick option to default to string if no schema infor…

a8602de

…mation yet.

GPII-2394 Clone of universal testData

2e17f69

Temporarily including a local set of testData to ease development.

Next round of initial work.

096bbed

Foundation Default _settings.scss

58ef643

Committing default _settings.scss from Foundation 6.3.0 before making modifications.

First round of changes from 2017-05-19 UI Review

d9000c5

- Removing markdown descriptions for now. - Changing "Add Pref Set" to "Add Context" - Removing context icons and earcons buttons since we don't have any yet. - Changed left hand product list to be <li>'s instead of <h4>'s

Working on gettign the request available per request in the options b…

c281b0d

…lock

GPII-2452 Renaming sidebar partial to make it a component.

56d3a91

GPII-2452

7b1a239

Factored left hand product list into a component and added a search filter to the top of it.

Putting in scaffolding to generate our own foundation scss for styling

cb7b4a3

GPII-2452 Next round of changes.

11ac391

- Numerous changes based off of continuing prototyping, and the UI review of June.

GPII-2452 Remove settings ref page

3c29cc5

- Removing half baked settings reference page

GPII-2452 Lunr Filter Search Consolidation

dc00db3

- Created utility routine for filtering an index - Updated usage in components - Added some unit tests for it

GPII-2452 Cleanup and Context Dialog Fix

ecb9c54

- Removing numerous console.log statements - Putting in a temporary fix for the add context dialog until it's refactored in to a proper component.

GPII-2452 Change product enabled switch labels.

4be5f68

- Changed to Yes/No based on UI Review

GPII-2452 Add reRender and remove old prefsFilter

476192e

GPII-2452 Added warning for leaving page. Cleanup.

5072631

GPII-2452 Removing unfactored project table template

12f4b51

GPII-2452 Renaming productList to follow convention

6702294

GPII-2452 Renaming editprefset.js

529153a

- Renaming editprefset.js to editprefset-viewport.

GPII-2452 Renamed editwidgets.js and template

c4449dc

GPII-2452 Update pref value on enter button

d134d4b

GPII-2452 Remove unused modelListners

8559322

GPII-2452 ModelRelay for Settings Table Filters

3afb2c7

- Setting up modelrelay from the main editPrefs component to the child product tables to save their search/filter settings in the event that page is rerendered, or we need to save all the settings.

sgithens added 3 commits May 20, 2019 13:18

GPII-2452 Removing the remaining custom dataSources which are no long…

7323b8d

…er needed

GPII-2452 Removing unused deps, updating project urls, minor include …

b1445a0

…fixes

GPII-2452 Pinning gpii-handlebars to specific npm dev release.

66f789d

amb26 reviewed May 27, 2019

View reviewed changes

src/js/client/editprefset-mineAllSwitch-widget.js Outdated Show resolved Hide resolved

amb26 reviewed May 27, 2019

View reviewed changes

src/js/client/editprefset-viewport.js Outdated Show resolved Hide resolved

amb26 reviewed May 27, 2019

View reviewed changes

src/js/client/helpers.js Outdated Show resolved Hide resolved

amb26 reviewed May 27, 2019

View reviewed changes

src/templates/partials/common-includes.handlebars Outdated Show resolved Hide resolved

sgithens added 6 commits May 27, 2019 13:55

GPII-2452 Removing unused js deps

061ebf9

GPII-2452 Removing unused debugging code and deps

66dd385

GPII-2452 Removing debug comment

491140c

GPII-2452 Added helpful comment

00c4837

GPII-2452 Removed unused code. Fixed up some handlebars helpers.

b403a0d

GPII-2452 Adding commend and link to GPII-2933

e9985e9

sgithens added 2 commits June 10, 2019 09:19

GPII-2452 Fixing up unit tests.

46c68da

GPII-2452 Updating README for current state of unit tests.

a82ec23

sgithens added 2 commits June 28, 2019 16:11

GPII-2452 Added setup details to README

3edad8c

GPII-2452 Minor typo

635fe7b

amb26 merged commit 635fe7b into GPII:master Jun 28, 2019

sgithens deleted the GPII-2452 branch November 1, 2019 20:23

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Gpii 2452 Initial Suggestions and Review #1

Gpii 2452 Initial Suggestions and Review #1

sgithens commented Aug 5, 2017

sgithens commented May 27, 2019

amb26 May 27, 2019

sgithens May 28, 2019

amb26 May 27, 2019

sgithens May 28, 2019

sgithens commented May 28, 2019

amb26 commented May 29, 2019

sgithens commented Jun 10, 2019

sgithens commented Jun 14, 2019

amb26 commented Jun 17, 2019

sgithens commented Jun 20, 2019 •

edited

Loading

sgithens commented Jun 23, 2019

amb26 commented Jun 28, 2019

Gpii 2452 Initial Suggestions and Review #1

Gpii 2452 Initial Suggestions and Review #1

Conversation

sgithens commented Aug 5, 2017

sgithens commented May 27, 2019

amb26 May 27, 2019

Choose a reason for hiding this comment

sgithens May 28, 2019

Choose a reason for hiding this comment

amb26 May 27, 2019

Choose a reason for hiding this comment

sgithens May 28, 2019

Choose a reason for hiding this comment

sgithens commented May 28, 2019

amb26 commented May 29, 2019

sgithens commented Jun 10, 2019

sgithens commented Jun 14, 2019

amb26 commented Jun 17, 2019

sgithens commented Jun 20, 2019 • edited Loading

sgithens commented Jun 23, 2019

amb26 commented Jun 28, 2019

sgithens commented Jun 20, 2019 •

edited

Loading