Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrating from vaerh provider, issue with bridge #104

Closed
durandguru opened this issue Feb 16, 2023 · 5 comments · Fixed by #105
Closed

Migrating from vaerh provider, issue with bridge #104

durandguru opened this issue Feb 16, 2023 · 5 comments · Fixed by #105
Assignees
Labels
bug Something isn't working

Comments

@durandguru
Copy link
Contributor

Describe the bug
I used the @vaerh provider before and want to switch to this one after the merge. If I only replace the provider and run a plan. It wants to create a new bridge.

To Reproduce
Current setup in vaerh provider:
resource "routeros_bridge" "bridge" {
name = "bridge"
ingress_filtering = true
priority = "0x3000"
vlan_filtering = true
}

Switch providers and run plan

routeros_bridge.bridge will be created

  • resource "routeros_bridge" "bridge" {
    • actual_mtu = (known after apply)
    • admin_mac = (known after apply)
    • ageing_time = "5m"
    • arp = "enabled"
    • arp_timeout = "auto"
    • auto_mac = true
    • disabled = false
    • ether_type = "0x8100"
    • fast_forward = (known after apply)
    • forward_delay = "15s"
    • frame_types = "admit-all"
    • id = (known after apply)
    • igmp_snooping = false
    • ingress_filtering = true
    • l2mtu = (known after apply)
    • mac_address = (known after apply)
    • max_message_age = "20s"
    • mtu = "auto"
    • name = "bridge"
    • priority = "0x3000"
    • protocol_mode = "rstp"
    • pvid = 1
    • running = (known after apply)
    • transmit_hold_count = 6
    • vlan_filtering = true
      }

Expected behavior
Just migrate

Additional context

@durandguru durandguru added the bug Something isn't working label Feb 16, 2023
@vaerh
Copy link
Collaborator

vaerh commented Feb 16, 2023

Can you test this solution?
https://developer.hashicorp.com/terraform/cli/commands/state/replace-provider
And please save your state file before that.

@durandguru
Copy link
Contributor Author

The same issue. The other resources managed in this project has no problems.
I performed terraform state replace-provider vaerh/routeros GNewbury1/routeros

@vaerh
Copy link
Collaborator

vaerh commented Feb 16, 2023

Okay, I think I know what the problem might be, but I need to get to my workbench to describe the solution.

@gfenn-newbury
Copy link
Collaborator

Yep, I think #103 created a breaking change, but was tagged as a patch version rather than major 🤦 Sorry, that's my mistake.

@durandguru for the time being, can you test with v1.0.2 instead of v1.0.3, and see if that works?

@vaerh I'll leave my pull requests open in the future until we've both reviewed them. I really should have spotted this

@durandguru
Copy link
Contributor Author

1.0.2 works

vaerh added a commit that referenced this issue Feb 16, 2023
gfenn-newbury added a commit that referenced this issue Feb 17, 2023
fix: Spaces in resource names (#102 - #104).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants