Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: automake on msys2 by appveyor #585

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

chcg
Copy link

@chcg chcg commented Oct 16, 2019

see https://github.com/hunspell/hunspell/blob/master/appveyor.yml

@chcg chcg force-pushed the automake_appveyor branch 2 times, most recently from 4e14578 to 21fda6d Compare October 16, 2019 21:24
@kevina kevina changed the title automake on msys2 by appveyor WIP: automake on msys2 by appveyor Oct 16, 2019
@chcg chcg force-pushed the automake_appveyor branch from 21fda6d to 6d05743 Compare October 16, 2019 21:44
@kevina
Copy link
Member

kevina commented Oct 16, 2019

This looks like it a work in progress. Please remove the WIP from the title and ping me when ready for review.

@chcg chcg force-pushed the automake_appveyor branch from 6d05743 to 9a94efb Compare October 16, 2019 22:02
@chcg
Copy link
Author

chcg commented Oct 16, 2019

@kevina Yes, just want to test the behaviour of mingw64 builds on circle ci compared to appveyor msys2 and "normal" gcc builds.

@kevina
Copy link
Member

kevina commented Oct 16, 2019

@chcg that's fine. in the future please prefix the p.r. title with a WIP: so I know not to spend any time looking at it.

@chcg chcg force-pushed the automake_appveyor branch 5 times, most recently from 4f91137 to 434949d Compare October 16, 2019 23:51
@chcg
Copy link
Author

chcg commented Nov 4, 2019

@kevina Is there a chance to get this:

#if ENABLE_NLS
#define printf printf
#include "libintl.h"
#undef printf
#endif

integrated for the necessary files? I think there was already some discussion on this in the past.

Based on https://github.com/msys2/MINGW-packages/blob/master/mingw-w64-aspell/0002-printf.mingw.patch

@kevina
Copy link
Member

kevina commented Nov 4, 2019

@chcg

What is the purpose of that? How many files will need to be modified? Would changing getext.h (the only file that includes libintl.h) work?

@chcg
Copy link
Author

chcg commented Nov 4, 2019

See https://circleci.com/gh/GNUAspell/aspell/814?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link

For mingw under circleci there is no gettext available:

checking for GNU gettext in libc... no
checking for iconv... no, consider installing GNU libiconv
checking for GNU gettext in libintl... no
checking whether to use NLS... no

what seems to differ from normal linux config (https://circleci.com/gh/GNUAspell/aspell/818?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link)

checking for GNU gettext in libc... yes
checking whether to use NLS... yes
checking where the gettext function comes from... libc

and also from windows appveyor msys2 version (https://ci.appveyor.com/project/chcg/aspell/builds/28165851):

checking for GNU gettext in libc... no
checking for iconv... yes
checking for working iconv... yes
checking how to link with libiconv... /mingw64/lib/libiconv.dll.a -L/mingw64/lib
checking for GNU gettext in libintl... yes
checking whether to use NLS... yes
checking where the gettext function comes from... external libintl
checking how to link with libintl... /mingw64/lib/libintl.dll.a -L/mingw64/lib

@chcg chcg force-pushed the automake_appveyor branch from 434949d to eae07b6 Compare December 30, 2019 11:39
@chcg chcg force-pushed the automake_appveyor branch 4 times, most recently from 9c13b11 to 43294f3 Compare May 18, 2020 14:36
@chcg chcg force-pushed the automake_appveyor branch from 43294f3 to c26fe59 Compare December 11, 2020 22:30
@chcg chcg force-pushed the automake_appveyor branch 7 times, most recently from 2b10aec to c5b4c44 Compare December 11, 2022 23:12
@chcg chcg force-pushed the automake_appveyor branch from c5b4c44 to 314273b Compare December 11, 2022 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants