-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: foundry #65
feat: foundry #65
Conversation
I also had an issue using this package with pnpm, based on a babel dependecy. This PR fixes that. |
Finally had time to review this PR. Sorry about the wait. None of the tests kept their functionality! 🙈 In fact, the one that you converted from My opinion is that regardless of how long this library has existed we shouldn't butcher all the tests and, if we do, we shouldn't keep them in a format where they don't really test anything we want them to. I honestly want to try and help you get this PR through the finish line but I don't have time to go into it too deep. I'd need you to keep the AssertBytes library being used in the tests and keep the tests relevant for me to accept this. |
One could argue that the tests you created are new tests that actually do differential testing with both my assertion methods and the compiler's internal ones, so I'd be happy to keep them, in addition. 👍 |
You make a great point about keeping the tests functional. Oops. I'll spend some time seeing if it's better to either keep or revert the foundry tests in addition to the solidity-bytes-utils/test/TestBytesLib1.sol Lines 41 to 43 in 42221d3
Nonetheless, I'll get this PR moving and keep our dependencies light. |
@GNSPS this is ready for review. |
OK, dope! LGTM! 🙏 Thank you for this, @pegahcarter! Merging and publishing in NPM. |
We have entered a new era of Forge and Foundry. As such, it is time to send truffle to the graveyard.
This PR:
ds-test
asserts.ds-test
does not support comparisons. However, given the duration this repo has been live without issue, it should be fine to comment out.I came across this change as truffle has outdated dependencies that still contain bugs.