Fix tabix histogram for CanvasFeatuers #956
Conversation
ghost
assigned 
|
HTMLFeatures don't seem to picking up the scale properly put canvas scale works |
|
Fixes #935 |
|
This also has a fix for 'addStores', which should have been done within the master branch, but it ended up here. It is the correct fix, however. |
| @@ -59,7 +59,7 @@ define(['dojo/_base/declare', 'JBrowse/Util/dot-object'], function (declare, dot | |||
| var storeTracks = {}; | |||
| var storeBookmarks = {}; | |||
| Object.keys(queryParams).forEach(function (queryParam) { | |||
| if (queryParam.indexOf('addStore\.') == 0) { | |||
| if (queryParam.indexOf('addStores\.') == 0) { | |||
There was a problem hiding this comment.
Could you add a block comment to the top of this file saying what this class does? For posterity.
There was a problem hiding this comment.
added doc at the top. Thanks.
| }, errorCallback); | ||
| }, | ||
|
|
||
| _count: function( ref, min, max, itemCallback, finishCallback, errorCallback ) { |
There was a problem hiding this comment.
this function doesn't look right. it is returning count synchronously, but it also calls an error callback.
and it's returning a count of the blocks in the range, not the lines. what's up here?
There was a problem hiding this comment.
good idea. I removed it as they weren't actually used.
|
@rbuels Ready for re-review assuming that everything passes. |
Fixes #935
add volvox example with BigWig if not there
add volvox exmple without BigWig
adjust feature density to sane default, confirm adjustment
allows current use of supplying alternate store such as BigWig
Provides automated feature density for GFF3Tabix versus CanvasFeatures
provides reasonably similar densities to HTMLFeatures (or at least sane defaults)