Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to index names for gff tabix (#780) #900

Merged
merged 1 commit into from
Mar 27, 2018
Merged

Add support to index names for gff tabix (#780) #900

merged 1 commit into from
Mar 27, 2018

Conversation

billzt
Copy link
Contributor

@billzt billzt commented Jun 16, 2017

Modified according to the functions of vcf names indexing. Aim to fix the fourth bug in #780

add support to generate-names.pl for gff tabix
@cmdcolin
Copy link
Contributor

this is great! does this only index the ID of the features? it could be useful to index other fields, possibly at the user's command

@billzt
Copy link
Contributor Author

billzt commented Jun 21, 2017

Yeah, this would be a little more complicated than vcf. Perhaps adding a novel parameter to generate-names.pl is more robust. However I'm not sure whether it is acceptable.

@cmdcolin
Copy link
Contributor

at least one thing that is sort of interesting is that with normal flatfile-to-json.pl on a gff file, you use the --nameAttributes parameter of flatfile-to-json.pl to determine what parameters of the gff you want to have indexed by generate-names.pl

so, potentially if the gff3tabix was incorporated into flatfile-to-json.pl then it might hook into that parameter

@nathanhaigh
Copy link
Contributor

Would this work for GFF3 files on remote storage? e.g. the baseUrl is an http address.

@rbuels rbuels added the needs review this needs investigation before work can be done label Jan 29, 2018
@rbuels
Copy link
Collaborator

rbuels commented Jan 29, 2018

@billzt sorry about the delay here. Would you be willing to add a test case for this to the automated tests in `tests/perl_tests/generate-names.pl.t?

@rbuels rbuels added this to the 1.12.4 milestone Jan 29, 2018
@rbuels rbuels added the feature req this adds new functionality to JBrowse 1 label Jan 29, 2018
@billzt
Copy link
Contributor Author

billzt commented Jan 31, 2018

@rbuels Sorry, I didn't know how to add the test ...

@rbuels rbuels modified the milestones: 1.12.4, 1.13.0 Feb 2, 2018
@nathandunn nathandunn changed the base branch from master to dev February 7, 2018 21:31
@rbuels rbuels modified the milestones: 1.13.0, 1.13.1 Mar 14, 2018
@rbuels rbuels merged commit ef79e6a into GMOD:dev Mar 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature req this adds new functionality to JBrowse 1 needs review this needs investigation before work can be done
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants