Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error with tooltips in embedded components in vite dev mode #4612

Merged
merged 2 commits into from
Oct 21, 2024

Conversation

cmdcolin
Copy link
Collaborator

@cmdcolin cmdcolin commented Oct 21, 2024

Vite dev mode for @jbrowse/react-linear-genome-view produces an error like this when you mouse over features on e.g. a bam track

image

Apparently the lazy import of @jbrowse/core/ui/BaseTooltip causes this

I tested this by a) creating this branch to remove the lazy import, and then created a vite example in our component_tests folder to test this build and then b) backported the vite component_tests folder onto main to confirm it fails without the lazy import change

@cmdcolin
Copy link
Collaborator Author

similar bugs have been seen with the lazy import of the AboutDialog in the past in vite....not really exactly sure the entire technical reasons for these things not working

@cmdcolin cmdcolin merged commit 4608823 into main Oct 21, 2024
4 checks passed
@cmdcolin cmdcolin deleted the too_much_lazy branch October 21, 2024 20:27
@cmdcolin cmdcolin added the bug Something isn't working label Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant