Remove storybook symlink workaround #2152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
needs label triage
garrettjstevens
added
internal
and removed
needs label triage
|
good stuff... this attention to storybook also made me find #2153 earlier today which was an important fix...good catch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like the bug that necessitated this workaround was fixed and released in storybook v6.2.2, and since we've upgraded to a minimum of storybook v6.3.4, this PR removes it.
It also changes the name of the package.json script from
build-storyboktobuild:storybook. The reason is that the executable is calledbuild-storybook, and it's good to avoid having the script name be the same as the executable name. This is because if you want to call the executable with different args than are in the script (e.g. calling it without--quiet), you can no longer useyarn build-storybookto do that because that calls the script instead of the executable.