Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix loading indicator on the reference sequence selector getting stuck #2119

Merged
merged 1 commit into from
Jul 13, 2021

Conversation

cmdcolin
Copy link
Collaborator

@cmdcolin cmdcolin commented Jul 9, 2021

Fixes #2118

Gets rid of useMemo statement. It could use assembly.regions as the parameter for useMemo but it is more straightforward i think to not useMemo here

@cmdcolin cmdcolin requested a review from teresam856 July 9, 2021 21:44
@github-actions github-actions bot added the needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) label Jul 9, 2021
@cmdcolin cmdcolin added bug Something isn't working and removed needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) labels Jul 9, 2021
@codecov
Copy link

codecov bot commented Jul 9, 2021

Codecov Report

Merging #2119 (8e63408) into main (045d35c) will increase coverage by 3.17%.
The diff coverage is 62.99%.

❗ Current head 8e63408 differs from pull request most recent head beb7000. Consider uploading reports for the commit beb7000 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2119      +/-   ##
==========================================
+ Coverage   58.84%   62.01%   +3.17%     
==========================================
  Files         459      476      +17     
  Lines       21390    22788    +1398     
  Branches     4986     5350     +364     
==========================================
+ Hits        12587    14133    +1546     
+ Misses       8492     8374     -118     
+ Partials      311      281      -30     
Impacted Files Coverage Δ
packages/core/BaseFeatureWidget/index.ts 75.00% <ø> (ø)
packages/core/Plugin.ts 100.00% <ø> (ø)
packages/core/ReExports/modules.ts 75.00% <ø> (ø)
packages/core/pluggableElementTypes/ViewType.ts 81.81% <ø> (ø)
packages/core/pluggableElementTypes/WidgetType.ts 81.81% <ø> (ø)
...re/pluggableElementTypes/models/baseTrackConfig.ts 58.33% <0.00%> (-2.54%) ⬇️
...ementTypes/renderers/ServerSideRenderedContent.tsx 0.00% <0.00%> (ø)
...entTypes/renderers/util/serializableFilterChain.ts 80.00% <ø> (ø)
packages/core/rpc/WebWorkerRpcDriver.ts 0.00% <0.00%> (ø)
packages/core/ui/Drawer.js 100.00% <ø> (ø)
... and 481 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5c11c1d...beb7000. Read the comment docs.

Copy link
Contributor

@teresam856 teresam856 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@teresam856 teresam856 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@cmdcolin cmdcolin force-pushed the fix_loading_indicator branch from 8e63408 to beb7000 Compare July 13, 2021 15:24
@cmdcolin cmdcolin merged commit 8f2dd7b into main Jul 13, 2021
@cmdcolin cmdcolin deleted the fix_loading_indicator branch July 13, 2021 15:28
@cmdcolin cmdcolin changed the title Fix loading indicator on refnameautocomplete being stuck Fix loading indicator on the reference sequence selector getting stuck Jul 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Infinite loading when switching assemblies
2 participants