Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "Can't resolve '@jbrowse/plugin-legacy-jbrowse'" in @jbrowse/react-linear-genome-view #2111

Merged
merged 1 commit into from
Jul 7, 2021

Conversation

garrettjstevens
Copy link
Collaborator

Removes one reference to the legacy JBrowse plugin from @jbrowse/react-linear-genome-view, which is causing the following error:

ERROR in ./node_modules/@jbrowse/react-linear-genome-view/dist/react-linear-genome-view.cjs.production.min.js
Module not found: Error: Can't resolve '@jbrowse/plugin-legacy-jbrowse' in './node_modules/@jbrowse/react-linear-genome-view/dist'

@garrettjstevens garrettjstevens self-assigned this Jul 7, 2021
@github-actions github-actions bot added the needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) label Jul 7, 2021
@garrettjstevens garrettjstevens force-pushed the remove_legacy_plugin_embedded branch from c3877ef to 4cec56f Compare July 7, 2021 02:09
@codecov
Copy link

codecov bot commented Jul 7, 2021

Codecov Report

Merging #2111 (4cec56f) into main (3039863) will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2111      +/-   ##
==========================================
+ Coverage   61.94%   61.96%   +0.02%     
==========================================
  Files         476      476              
  Lines       22792    22792              
  Branches     5351     5351              
==========================================
+ Hits        14118    14124       +6     
+ Misses       8391     8385       -6     
  Partials      283      283              
Impacted Files Coverage Δ
...browse-react-linear-genome-view/src/corePlugins.ts 100.00% <ø> (ø)
packages/core/util/index.ts 78.30% <0.00%> (ø)
...nts/src/SNPCoverageRenderer/SNPCoverageRenderer.ts 87.65% <0.00%> (+7.40%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3039863...4cec56f. Read the comment docs.

@cmdcolin
Copy link
Collaborator

cmdcolin commented Jul 7, 2021

Good catch. Without this fix, the embedded code is not really able to be used. Maybe we can go ahead and merge and make a hotfix release?

@cmdcolin cmdcolin added bug Something isn't working and removed needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) labels Jul 7, 2021
@cmdcolin cmdcolin merged commit 9a8dbd0 into main Jul 7, 2021
@cmdcolin cmdcolin deleted the remove_legacy_plugin_embedded branch July 7, 2021 02:56
@cmdcolin
Copy link
Collaborator

cmdcolin commented Jul 7, 2021

I think it is good to get this released asap! Went ahead and merged

@Akusem
Copy link
Contributor

Akusem commented Jul 7, 2021

@cmdcolin @garrettjstevens
Thanks for the fast hotfix !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants