Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make tracks added using the add track widget a session track if not in adminMode #2001

Merged
merged 1 commit into from
May 21, 2021
Merged

Make tracks added using the add track widget a session track if not in adminMode #2001

merged 1 commit into from
May 21, 2021

Conversation

cmdcolin
Copy link
Collaborator

Fixes #1991

@github-actions github-actions bot added the needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) label May 21, 2021
@cmdcolin cmdcolin requested a review from garrettjstevens May 21, 2021 18:43
@cmdcolin cmdcolin added enhancement New feature or request and removed needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) labels May 21, 2021
@codecov
Copy link

codecov bot commented May 21, 2021

Codecov Report

Merging #2001 (a9ef30a) into main (b7560ca) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2001      +/-   ##
==========================================
- Coverage   60.97%   60.97%   -0.01%     
==========================================
  Files         471      471              
  Lines       22513    22514       +1     
  Branches     5228     5229       +1     
==========================================
- Hits        13728    13727       -1     
- Misses       8502     8504       +2     
  Partials      283      283
Impacted Files Coverage Δ
...t/src/AddTrackWidget/components/AddTrackWidget.tsx 48.78% <0.00%> (-1.22%) ⬇️
packages/core/util/index.ts 77.92% <0.00%> (-0.27%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b7560ca...a9ef30a. Read the comment docs.

@cmdcolin cmdcolin changed the title Make tracks added using the add track widget into session tracks if not in adminMode Make tracks added using the add track widget a session track if not in adminMode May 21, 2021
@cmdcolin cmdcolin merged commit aae2f7d into main May 21, 2021
@cmdcolin cmdcolin deleted the session_track_addtrack branch May 21, 2021 19:43
@garrettjstevens garrettjstevens mentioned this pull request May 21, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@garrettjstevens garrettjstevens garrettjstevens approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tracks added via GUI in non-admin JBrowse Web don't get categorized in session tracks
2 participants
@cmdcolin @garrettjstevens