Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass initialDisplay snapshot via separate param to showTrack #1995

Merged
merged 2 commits into from
May 26, 2021

Conversation

cmdcolin
Copy link
Collaborator

The showTrack has a "initial snapshot" method that it can use to instantiate track specific state, but it is also useful to be able to initialize display specific state too (in the GDC plugin, we can use this to provide initial min and max scores for wiggle display for dynamically added tracks for example)

@github-actions github-actions bot added the needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) label May 20, 2021
@cmdcolin cmdcolin force-pushed the initial_snapshot_2 branch from 596b895 to cf86a35 Compare May 21, 2021 17:10
@codecov
Copy link

codecov bot commented May 21, 2021

Codecov Report

Merging #1995 (cf86a35) into main (739a00e) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1995   +/-   ##
=======================================
  Coverage   60.97%   60.97%           
=======================================
  Files         471      471           
  Lines       22512    22514    +2     
  Branches     5174     5230   +56     
=======================================
+ Hits        13726    13728    +2     
+ Misses       8510     8503    -7     
- Partials      276      283    +7     
Impacted Files Coverage Δ
.../linear-genome-view/src/LinearGenomeView/index.tsx 83.81% <100.00%> (+0.05%) ⬆️
products/jbrowse-desktop/src/factoryReset.ts 0.00% <0.00%> (ø)
...s/alignments/src/PileupRenderer/PileupRenderer.tsx 56.67% <0.00%> (ø)
...y-jbrowse/src/JBrowse1Connection/jb1ConfigParse.ts 23.21% <0.00%> (ø)
...src/LinearPileupDisplay/components/FilterByTag.tsx 0.00% <0.00%> (ø)
...rc/LinearPileupDisplay/components/SetMaxHeight.tsx 0.00% <0.00%> (ø)
...eElementTypes/renderers/ServerSideRendererType.tsx 26.19% <0.00%> (ø)
...src/LinearBasicDisplay/components/SetMaxHeight.tsx 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 739a00e...cf86a35. Read the comment docs.

@cmdcolin cmdcolin added internal and removed needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) labels May 24, 2021
@rbuels rbuels merged commit 2a3e83a into main May 26, 2021
@rbuels rbuels deleted the initial_snapshot_2 branch May 26, 2021 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants