Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid error calculating UTR on features that have no exon subfeatures #1985

Merged
merged 1 commit into from
May 17, 2021

Conversation

cmdcolin
Copy link
Collaborator

As title says, UTR prediction is not done if no exon subfeatures are available. Fixes #1983

@github-actions github-actions bot added the needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) label May 17, 2021
@codecov
Copy link

codecov bot commented May 17, 2021

Codecov Report

Merging #1985 (62f6568) into main (905e690) will decrease coverage by 0.03%.
The diff coverage is 14.28%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1985      +/-   ##
==========================================
- Coverage   61.38%   61.35%   -0.04%     
==========================================
  Files         470      470              
  Lines       22216    22222       +6     
  Branches     5100     5100              
==========================================
- Hits        13637    13634       -3     
- Misses       8304     8313       +9     
  Partials      275      275              
Impacted Files Coverage Δ
.../core/BaseFeatureWidget/SequenceFeatureDetails.tsx 51.51% <14.28%> (-1.95%) ⬇️
...inearGenomeView/components/RefNameAutocomplete.tsx 89.36% <0.00%> (-4.26%) ⬇️
packages/core/util/index.ts 78.19% <0.00%> (-0.27%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 905e690...62f6568. Read the comment docs.

@cmdcolin cmdcolin force-pushed the no_utr_prediction_if_no_exons branch from 62f6568 to ad0086e Compare May 17, 2021 18:26
@cmdcolin cmdcolin merged commit d8717fd into main May 17, 2021
@cmdcolin cmdcolin deleted the no_utr_prediction_if_no_exons branch May 17, 2021 22:36
@garrettjstevens garrettjstevens added bug Something isn't working and removed needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) labels May 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

jbrowse fails to fetch sequence and does not recognize GFF3 correctly
2 participants