Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow manually specifying adapter type if filename does not match expected pattern #1982

Merged
merged 15 commits into from
May 19, 2021

Conversation

cmdcolin
Copy link
Collaborator

Fixes #1885

@github-actions github-actions bot added the needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) label May 17, 2021
@cmdcolin
Copy link
Collaborator Author

This is an add on to #1975 so is based on that branch

@cmdcolin cmdcolin added enhancement New feature or request and removed needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) labels May 17, 2021
@codecov
Copy link

codecov bot commented May 17, 2021

Codecov Report

Merging #1982 (1a86b2b) into allow_local_file_blobs_jbweb (d34eb9a) will increase coverage by 0.00%.
The diff coverage is 62.16%.

❗ Current head 1a86b2b differs from pull request most recent head 9085d76. Consider uploading reports for the commit 9085d76 to get more accurate results
Impacted file tree graph

@@                      Coverage Diff                      @@
##           allow_local_file_blobs_jbweb    #1982   +/-   ##
=============================================================
  Coverage                         61.37%   61.37%           
=============================================================
  Files                               470      470           
  Lines                             22243    22252    +9     
  Branches                           5113     5114    +1     
=============================================================
+ Hits                              13652    13658    +6     
- Misses                             8316     8319    +3     
  Partials                            275      275           
Impacted Files Coverage Δ
...ent/src/AddTrackWidget/components/ConfirmTrack.tsx 2.43% <0.00%> (-0.34%) ⬇️
...lugins/data-management/src/AddTrackWidget/model.ts 62.22% <40.00%> (ø)
packages/core/util/tracks.ts 64.86% <95.45%> (+3.18%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d34eb9a...9085d76. Read the comment docs.

@cmdcolin cmdcolin changed the base branch from allow_local_file_blobs_jbweb to main May 19, 2021 19:51
@cmdcolin cmdcolin merged commit 739a00e into main May 19, 2021
@cmdcolin cmdcolin deleted the adapter_hint branch May 19, 2021 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to manually specify adapter for unknown filename format
1 participant