Add more environments to configSchema create calls to fix ability to use custom jexl commands with main thread rendering #1954
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up to the #1945 which found that main thread rendering can produce errors if a plugin has added custom jexl functions and the plugin is trying to use them
The reason is explained in #1945 but the summary is that if this is not done, a jexl instance is created automatically and will only contain default commands
The target branch is currently #fix_hic but if that is merged, should be good to go, then this could be an add-on
If there is anything I missed let me know
I basically looked at all instances searching using "ag create(" in the codebase and looked for instances of this pattern, which generally is the renderProps on a model function dynamically creating a renderer config