Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more environments to configSchema create calls to fix ability to use custom jexl commands with main thread rendering #1954

Merged
merged 6 commits into from
May 14, 2021

Conversation

cmdcolin
Copy link
Collaborator

This is a follow up to the #1945 which found that main thread rendering can produce errors if a plugin has added custom jexl functions and the plugin is trying to use them

The reason is explained in #1945 but the summary is that if this is not done, a jexl instance is created automatically and will only contain default commands

The target branch is currently #fix_hic but if that is merged, should be good to go, then this could be an add-on

If there is anything I missed let me know

I basically looked at all instances searching using "ag create(" in the codebase and looked for instances of this pattern, which generally is the renderProps on a model function dynamically creating a renderer config

@github-actions github-actions bot added the needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) label May 10, 2021
@cmdcolin cmdcolin added bug Something isn't working and removed needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) labels May 10, 2021
@cmdcolin cmdcolin changed the title Add more env environments to configSchema create calls Add more env environments to configSchema create calls to fix ability to use custom jexl commands with main thread rendering May 10, 2021
Base automatically changed from fix_hic to main May 10, 2021 21:29
@cmdcolin cmdcolin changed the title Add more env environments to configSchema create calls to fix ability to use custom jexl commands with main thread rendering Add more environments to configSchema create calls to fix ability to use custom jexl commands with main thread rendering May 10, 2021
@cmdcolin cmdcolin requested a review from peterkxie May 10, 2021 21:39
@codecov
Copy link

codecov bot commented May 11, 2021

Codecov Report

Merging #1954 (601e374) into main (8951f54) will increase coverage by 0.09%.
The diff coverage is 60.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1954      +/-   ##
==========================================
+ Coverage   59.99%   60.08%   +0.09%     
==========================================
  Files         459      459              
  Lines       21698    21697       -1     
  Branches     5080     5080              
==========================================
+ Hits        13018    13037      +19     
+ Misses       8380     8360      -20     
  Partials      300      300              
Impacted Files Coverage Δ
packages/core/data_adapters/dataAdapterCache.ts 75.00% <ø> (ø)
...ConnectionWidget/components/AddConnectionWidget.js 90.00% <ø> (ø)
plugins/hic/src/LinearHicDisplay/model.ts 75.00% <ø> (-1.00%) ⬇️
...ments/src/LinearSNPCoverageDisplay/models/model.ts 69.23% <42.85%> (ø)
...lugins/alignments/src/LinearPileupDisplay/model.ts 69.23% <100.00%> (ø)
...linear-genome-view/src/LinearBasicDisplay/model.ts 68.08% <100.00%> (ø)
...ns/wiggle/src/LinearWiggleDisplay/models/model.tsx 70.29% <100.00%> (ø)
...inearGenomeView/components/RefNameAutocomplete.tsx 89.36% <0.00%> (-4.26%) ⬇️
...view/src/SpreadsheetView/models/SpreadsheetView.ts 37.68% <0.00%> (+5.79%) ⬆️
...et-view/src/SpreadsheetView/models/ImportWizard.ts 71.13% <0.00%> (+11.34%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8951f54...601e374. Read the comment docs.

@rbuels rbuels merged commit 93628d5 into main May 14, 2021
@rbuels rbuels deleted the add_more_envs branch May 14, 2021 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants