Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create in app graphical plugin store #1931

Merged
merged 69 commits into from
May 11, 2021
Merged

Create in app graphical plugin store #1931

merged 69 commits into from
May 11, 2021

Conversation

elliothershberg
Copy link
Member

@elliothershberg elliothershberg commented Apr 28, 2021

This is currently a draft PR while I get a few things figured out, but works for web. Opening this so I have a better view of the diff on this branch and the state of the CI.

Remaining work:

  • Get things working in desktop
  • Write tests 😅
  • Merge main and resolve conflicts

This closes #336 and also closes #1686 .

Screenshots:

Screen Shot 2021-05-11 at 3 49 08 PM

With MsaView open:

Screen Shot 2021-05-11 at 3 59 55 PM

@codecov
Copy link

codecov bot commented May 6, 2021

Codecov Report

Merging #1931 (a3cf8e8) into main (8951f54) will increase coverage by 0.11%.
The diff coverage is 57.27%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1931      +/-   ##
==========================================
+ Coverage   59.99%   60.11%   +0.11%     
==========================================
  Files         459      467       +8     
  Lines       21698    21889     +191     
  Branches     5080     5103      +23     
==========================================
+ Hits        13018    13158     +140     
- Misses       8380     8429      +49     
- Partials      300      302       +2     
Impacted Files Coverage Δ
packages/core/ui/FileSelector.tsx 68.62% <ø> (-0.61%) ⬇️
packages/core/ui/RecentSessionCard.js 14.28% <ø> (ø)
products/jbrowse-desktop/src/Loader.tsx 0.00% <0.00%> (ø)
products/jbrowse-desktop/src/jbrowseModel.js 15.49% <0.00%> (-2.25%) ⬇️
products/jbrowse-desktop/src/rootModel.ts 36.11% <0.00%> (-1.39%) ⬇️
products/jbrowse-web/src/AdminComponent.tsx 0.00% <0.00%> (ø)
products/jbrowse-web/src/Loader.tsx 55.63% <0.00%> (-3.44%) ⬇️
products/jbrowse-desktop/src/JBrowse.js 55.17% <16.66%> (-3.01%) ⬇️
products/jbrowse-web/src/sessionModelFactory.ts 60.18% <38.46%> (-0.93%) ⬇️
plugins/data-management/src/index.ts 73.68% <42.85%> (-6.97%) ⬇️
... and 26 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8951f54...a3cf8e8. Read the comment docs.

@cmdcolin
Copy link
Collaborator

random note but we could, once we do something like this PR, avoid popping up warning dialogs for external configs on other domains. this is helpful for example in our plugins where we demonstrate them by linking them link https://s3.amazonaws.com/jbrowse.org/code/jb2/main/index.html?config=<cross domain here>

probably the warning popup could be avoided if the plugin is whitelisted aka found in the plugins.json

@elliothershberg
Copy link
Member Author

Yeah, I think that would be good to do

@elliothershberg elliothershberg added enhancement New feature or request and removed needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) labels May 11, 2021
@elliothershberg elliothershberg marked this pull request as ready for review May 11, 2021 18:29
@elliothershberg elliothershberg requested a review from rbuels May 11, 2021 18:29
@rbuels
Copy link
Contributor

rbuels commented May 11, 2021

this looks great! few little nits to pick:

  • can we get some screen shots in here? This feature will be released with some fanfare, and we will want some nice screen shots
  • can we make this widget lazy-loaded? this will probably be used relatively infrequently by end users

@rbuels
Copy link
Contributor

rbuels commented May 11, 2021

I say merge once the above is done

@elliothershberg
Copy link
Member Author

I say merge once the above is done

On it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

session plugins plugin store GUI
3 participants