-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create in app graphical plugin store #1931
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1931 +/- ##
==========================================
+ Coverage 59.99% 60.11% +0.11%
==========================================
Files 459 467 +8
Lines 21698 21889 +191
Branches 5080 5103 +23
==========================================
+ Hits 13018 13158 +140
- Misses 8380 8429 +49
- Partials 300 302 +2
Continue to review full report at Codecov.
|
random note but we could, once we do something like this PR, avoid popping up warning dialogs for external configs on other domains. this is helpful for example in our plugins where we demonstrate them by linking them link probably the warning popup could be avoided if the plugin is whitelisted aka found in the plugins.json |
Yeah, I think that would be good to do |
this looks great! few little nits to pick:
|
I say merge once the above is done |
On it! |
This is currently a draft PR while I get a few things figured out, but works for web. Opening this so I have a better view of the diff on this branch and the state of the CI.
Remaining work:
This closes #336 and also closes #1686 .
Screenshots:
With MsaView open: