Fix breakpoint split view visualizations for files that need ref renaming (e.g. chr1 vs 1) #1911
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1902
This makes sure to use canonical refname when searching.
There are possible alternatives to this PR
We could try to make all our adapters return features with a field called feature.get('originalRefName') that can be used for purposes like this (note that adapters do receive a parameter called region.originalRefName which is the canonical ref name for the assembly being views to their getFeatures function)
This could either
a) be the adapters responsibility to fill out this field or
b) be some sort of auto-added thing by some other aspect of our system (renderer/serialization/adapter/something else?)
Or we stick with this this type of solution, and wait until we find a good abstraction