Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --delete to set-default-session, fix --session #1878

Merged
merged 2 commits into from
Apr 9, 2021

Conversation

garrettjstevens
Copy link
Collaborator

This PR is a couple of small changes from when I was trying to figure out #1873.

  • Fixes jbrowse set-default-session --session session.json so that it expects a session JSON file. It was previously expecting a config JSON file. Also added support for the session being in a top-level "session" attribute on the session JSON so that files created with File -> Export session can be used with set-default-session
  • Adds a --delete option to set-default-session that removes the "defaultSession" from the config. Setting the default session to null or {} using set-default-session --session file.json caused errors, so this adds an easy way to clear the default session.

Was expecting a config file, when it should have been expecting a
session file.
@garrettjstevens garrettjstevens added bug Something isn't working enhancement New feature or request labels Apr 5, 2021
@garrettjstevens garrettjstevens self-assigned this Apr 5, 2021
@codecov
Copy link

codecov bot commented Apr 5, 2021

Codecov Report

Merging #1878 (64b0c75) into main (96256e1) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1878   +/-   ##
=======================================
  Coverage   58.52%   58.52%           
=======================================
  Files         460      460           
  Lines       21288    21294    +6     
  Branches     5059     5061    +2     
=======================================
+ Hits        12459    12463    +4     
- Misses       8524     8526    +2     
  Partials      305      305           
Impacted Files Coverage Δ
...ts/jbrowse-cli/src/commands/set-default-session.ts 96.36% <100.00%> (+0.44%) ⬆️
...r-view/src/BaseChordDisplay/components/Loading.tsx 95.00% <0.00%> (-5.00%) ⬇️
...inearGenomeView/components/RefNameAutocomplete.tsx 89.36% <0.00%> (-4.26%) ⬇️
packages/core/util/index.ts 81.28% <0.00%> (ø)
...ments/src/SNPCoverageAdapter/SNPCoverageAdapter.ts 95.00% <0.00%> (+0.83%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 96256e1...64b0c75. Read the comment docs.

@rbuels rbuels merged commit e9521d2 into main Apr 9, 2021
@rbuels rbuels deleted the set_default_session_updates branch April 9, 2021 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants