Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash on dotplot/linear synteny import form and when closing linear synteny track #1871

Merged
merged 2 commits into from
Apr 2, 2021

Conversation

cmdcolin
Copy link
Collaborator

@cmdcolin cmdcolin commented Apr 2, 2021

Currently, there are a couple of crashes in synteny workflows

  1. Closing a linear synteny track produces an error on getContainingView of displayModel
  2. Opening a dotplot or linear synteny view in the import form without a PAF file specified produces a crash

@github-actions github-actions bot added the needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) label Apr 2, 2021
@cmdcolin cmdcolin added bug Something isn't working and removed needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) labels Apr 2, 2021
@codecov
Copy link

codecov bot commented Apr 2, 2021

Codecov Report

Merging #1871 (0cab769) into main (c384d5f) will decrease coverage by 0.02%.
The diff coverage is 7.69%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1871      +/-   ##
==========================================
- Coverage   58.56%   58.54%   -0.03%     
==========================================
  Files         460      460              
  Lines       21331    21335       +4     
  Branches     5090     5088       -2     
==========================================
- Hits        12493    12491       -2     
- Misses       8532     8538       +6     
  Partials      306      306              
Impacted Files Coverage Δ
...tenyRenderer/components/LinearSyntenyRendering.tsx 1.63% <0.00%> (-0.06%) ⬇️
...ew/src/LinearSyntenyView/components/ImportForm.tsx 6.52% <0.00%> (ø)
...lot-view/src/DotplotView/components/ImportForm.tsx 78.04% <100.00%> (ø)
...inearGenomeView/components/RefNameAutocomplete.tsx 89.36% <0.00%> (-4.26%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c384d5f...0cab769. Read the comment docs.

@cmdcolin cmdcolin merged commit b2257d6 into main Apr 2, 2021
@cmdcolin cmdcolin changed the title Fix some synteny workflow crashes Fix crash on dotplot/linear synteny import form and when closing linear synteny track Apr 2, 2021
@cmdcolin cmdcolin deleted the fix_some_synteny_crashes branch April 2, 2021 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant