Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update @gmod/indexedfasta #1863

Merged
merged 4 commits into from
Apr 1, 2021
Merged

Update @gmod/indexedfasta #1863

merged 4 commits into from
Apr 1, 2021

Conversation

cmdcolin
Copy link
Collaborator

Bumps @gmod/indexedfasta to 2.0.0 for the getSequenceNames change

@github-actions github-actions bot added the needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) label Mar 31, 2021
@cmdcolin
Copy link
Collaborator Author

Appears to have some issue with simple version bump, see issue https://github.com/GMOD/jbrowse-components/pull/1863/checks?check_run_id=2239501908

Marked as draft

@cmdcolin cmdcolin marked this pull request as draft March 31, 2021 18:22
@cmdcolin cmdcolin added internal and removed needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) labels Mar 31, 2021
@codecov
Copy link

codecov bot commented Mar 31, 2021

Codecov Report

Merging #1863 (a8e548f) into main (17e0ed1) will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1863   +/-   ##
=======================================
  Coverage   59.19%   59.19%           
=======================================
  Files         459      459           
  Lines       21351    21351           
  Branches     5008     5008           
=======================================
  Hits        12639    12639           
  Misses       8405     8405           
  Partials      307      307           
Impacted Files Coverage Δ
...nce/src/IndexedFastaAdapter/IndexedFastaAdapter.ts 75.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 17e0ed1...a8e548f. Read the comment docs.

@cmdcolin cmdcolin marked this pull request as ready for review April 1, 2021 20:11
@rbuels rbuels merged commit c3aa04f into main Apr 1, 2021
@rbuels rbuels deleted the bump_indexedfasta branch April 1, 2021 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants