-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add example for using a build-time included plugin to storybook #1862
Conversation
appears to have some issues with a postinstall step, maybe put into draft |
this did work locally though which was interesting |
b39e991
to
d42ea7b
Compare
This may have to be closed if we can't resolve the build issue/CI. I think it's worthwhile to make sure that we document how to use build-time plugins, and having an example like this would be good but it causes the CI failure. Any ideas? something related to plugin postinstall script |
Hmm, yeah that would be good to have. I can try taking a look at this later. |
d42ea7b
to
744d3db
Compare
This now uses a source code comment to describe how to use build time plugins, rather than provide an actual example that uses build time plugins |
Codecov Report
@@ Coverage Diff @@
## main #1862 +/- ##
=======================================
Coverage 58.80% 58.80%
=======================================
Files 460 460
Lines 21735 21735
Branches 5198 5198
=======================================
Hits 12781 12781
Misses 8653 8653
Partials 301 301 Continue to review full report at Codecov.
|
744d3db
to
2c19a3c
Compare
this pr was pared down to basically just a comment now |
The storybook has an example of runtime-including a plugin but it is actually probably more common to use build-time plugins, so I added an example of that here
This adds a devDependency on jbrowse-plugin-ucsc to use as an example