Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Alignments track "Fade mismatches by quality" setting to a separate config param and made it less strict #1861

Merged
merged 3 commits into from
Apr 1, 2021

Conversation

cmdcolin
Copy link
Collaborator

The "Color by" scheme for alignments currently has 'Fade mismatches by quality'

Instead of making this specifically a property of "Color by", I change this to a separate setting

Then I also make the fading less "strict" e.g. right now it is a scale on a 0-90 but I make it on 0-50 because at quality 40, you are 99.99% sure the base call is right (see https://learn.gencore.bio.nyu.edu/wp-content/uploads/2018/01/Screen-Shot-2018-01-07-at-1.36.09-PM-768x535.png) and so you really only need to worry at like 20 or less. Even though phred can go up to 90 it does not need to really be faded after 50 or so I think

@github-actions github-actions bot added the needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) label Mar 31, 2021
@cmdcolin cmdcolin added enhancement New feature or request and removed needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) labels Mar 31, 2021
@cmdcolin
Copy link
Collaborator Author

this is also listed as true by default here, could consider turning off by default though

@codecov
Copy link

codecov bot commented Mar 31, 2021

Codecov Report

Merging #1861 (7c53b5c) into main (1ed6ae8) will decrease coverage by 0.01%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1861      +/-   ##
==========================================
- Coverage   59.18%   59.17%   -0.02%     
==========================================
  Files         460      460              
  Lines       21402    21408       +6     
  Branches     5024     5026       +2     
==========================================
+ Hits        12667    12668       +1     
- Misses       8428     8433       +5     
  Partials      307      307              
Impacted Files Coverage Δ
...lugins/alignments/src/LinearPileupDisplay/model.ts 68.42% <37.50%> (-0.61%) ⬇️
...ns/alignments/src/PileupRenderer/PileupRenderer.ts 65.65% <100.00%> (ø)
plugins/alignments/src/BamAdapter/BamAdapter.ts 69.51% <0.00%> (-1.22%) ⬇️
...ments/src/SNPCoverageAdapter/SNPCoverageAdapter.ts 94.16% <0.00%> (-0.84%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1ed6ae8...7c53b5c. Read the comment docs.

@cmdcolin cmdcolin force-pushed the mismatch_alpha_setting branch from 374f4a8 to d716e22 Compare March 31, 2021 14:31
@cmdcolin cmdcolin force-pushed the mismatch_alpha_setting branch from d716e22 to 7c53b5c Compare March 31, 2021 14:51
@cmdcolin
Copy link
Collaborator Author

Actually just made it off by default. it's on by default in igv but it's a little niche and could be unexpected

@rbuels rbuels merged commit 360ee31 into main Apr 1, 2021
@rbuels rbuels deleted the mismatch_alpha_setting branch April 1, 2021 21:34
@rbuels rbuels changed the title Change "Fade mismatches by quality" setting to separate config param and make less strict Change Alignments track "Fade mismatches by quality" setting to a separate config param and made it less strict Apr 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants