-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make "About track" dialog available from tracklist and for non-LGV tracks #1854
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1854 +/- ##
==========================================
- Coverage 58.56% 58.53% -0.04%
==========================================
Files 460 460
Lines 21331 21284 -47
Branches 5090 5061 -29
==========================================
- Hits 12493 12459 -34
+ Misses 8532 8520 -12
+ Partials 306 305 -1
Continue to review full report at Codecov.
|
d578f1b
to
48a1b6a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is probably ok to go in as is, but it does have a lot of uses of any
, and files that disable no-explicit-any for the whole file, which I think we should probably disallow.
Any way we can get the types a little better specified?
Replaced a couple any with AnyConfigurationModel, should be mostly fixed |
Propagated about track dialog to desktop and @jbrowse/react-linear-genome-view now too |
b65dcad
to
be7b3f8
Compare
a9c4118
to
cc2e7b6
Compare
The ability to view the "About track" dialog is currently in LGV
This change allows a dotplot to have an "About track" dialog box too now
It also allows a track that has not yet been opened to have an "About track" access, directly from the dropdown in the tracklist