Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make "About track" dialog available from tracklist and for non-LGV tracks #1854

Merged
merged 14 commits into from
Apr 2, 2021

Conversation

cmdcolin
Copy link
Collaborator

The ability to view the "About track" dialog is currently in LGV

This change allows a dotplot to have an "About track" dialog box too now

It also allows a track that has not yet been opened to have an "About track" access, directly from the dropdown in the tracklist

@github-actions github-actions bot added the needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) label Mar 29, 2021
@cmdcolin cmdcolin added enhancement New feature or request and removed needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) labels Mar 29, 2021
@codecov
Copy link

codecov bot commented Mar 29, 2021

Codecov Report

Merging #1854 (cc2e7b6) into main (c384d5f) will decrease coverage by 0.03%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1854      +/-   ##
==========================================
- Coverage   58.56%   58.53%   -0.04%     
==========================================
  Files         460      460              
  Lines       21331    21284      -47     
  Branches     5090     5061      -29     
==========================================
- Hits        12493    12459      -34     
+ Misses       8532     8520      -12     
+ Partials      306      305       -1     
Impacted Files Coverage Δ
packages/core/util/types/index.ts 61.53% <ø> (ø)
...c/LinearGenomeView/components/LinearGenomeView.tsx 73.52% <ø> (-0.83%) ⬇️
...roducts/jbrowse-desktop/src/sessionModelFactory.ts 1.62% <0.00%> (-0.03%) ⬇️
...-genome-view/src/createModel/createSessionModel.ts 16.21% <42.85%> (+1.32%) ⬆️
...ore/pluggableElementTypes/models/BaseTrackModel.ts 37.36% <50.00%> (-2.64%) ⬇️
...view/src/JBrowseLinearGenomeView/ViewContainer.tsx 54.54% <50.00%> (-1.02%) ⬇️
packages/core/ui/AboutDialog.tsx 75.00% <75.00%> (ø)
packages/core/ui/ViewContainer.tsx 78.57% <83.33%> (+0.79%) ⬆️
products/jbrowse-web/src/sessionModelFactory.ts 63.10% <83.33%> (+0.48%) ⬆️
...kages/core/BaseFeatureWidget/BaseFeatureDetail.tsx 79.69% <100.00%> (+0.15%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c384d5f...cc2e7b6. Read the comment docs.

@cmdcolin cmdcolin force-pushed the move_about_dialog_core branch from d578f1b to 48a1b6a Compare March 30, 2021 16:20
Copy link
Contributor

@rbuels rbuels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is probably ok to go in as is, but it does have a lot of uses of any, and files that disable no-explicit-any for the whole file, which I think we should probably disallow.

Any way we can get the types a little better specified?

@cmdcolin
Copy link
Collaborator Author

cmdcolin commented Apr 1, 2021

Replaced a couple any with AnyConfigurationModel, should be mostly fixed

@cmdcolin
Copy link
Collaborator Author

cmdcolin commented Apr 1, 2021

Propagated about track dialog to desktop and @jbrowse/react-linear-genome-view now too

@cmdcolin cmdcolin force-pushed the move_about_dialog_core branch 3 times, most recently from b65dcad to be7b3f8 Compare April 2, 2021 01:20
@cmdcolin cmdcolin force-pushed the move_about_dialog_core branch from a9c4118 to cc2e7b6 Compare April 2, 2021 19:57
@cmdcolin cmdcolin merged commit 1a50f3a into main Apr 2, 2021
@cmdcolin cmdcolin deleted the move_about_dialog_core branch April 2, 2021 22:50
@cmdcolin cmdcolin changed the title Move about dialog to core and make available from the track list Make "About track" dialog available from tracklist and for non-LGV tracks Apr 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants