Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve copy+paste in the data grids for feature details #1846

Merged
merged 5 commits into from
Mar 25, 2021

Conversation

cmdcolin
Copy link
Collaborator

This makes better data grid copy+paste operations in reference to mui/mui-x#1197

It also turns off the sample filter panel in variant feature details by default as it can be a little specialized

@github-actions github-actions bot added the needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) label Mar 25, 2021
@rbuels rbuels added enhancement New feature or request and removed needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) labels Mar 25, 2021
@rbuels rbuels changed the title Miscellaneous data grid improvements Miscellaneous data grid improvements in feature details widget Mar 25, 2021
@cmdcolin cmdcolin force-pushed the misc_datagrid_improvements branch from 4edce4b to 9019481 Compare March 25, 2021 01:12
@codecov
Copy link

codecov bot commented Mar 25, 2021

Codecov Report

Merging #1846 (87bee39) into main (2eb79ef) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1846      +/-   ##
==========================================
- Coverage   59.02%   59.01%   -0.01%     
==========================================
  Files         461      461              
  Lines       21473    21473              
  Branches     5031     5031              
==========================================
- Hits        12674    12672       -2     
- Misses       8485     8487       +2     
  Partials      314      314              
Impacted Files Coverage Δ
...kages/core/BaseFeatureWidget/BaseFeatureDetail.tsx 76.61% <ø> (ø)
.../src/VariantFeatureWidget/VariantFeatureWidget.tsx 40.00% <100.00%> (-4.00%) ⬇️
...ments/src/SNPCoverageAdapter/SNPCoverageAdapter.ts 94.16% <0.00%> (-0.84%) ⬇️
...inearGenomeView/components/RefNameAutocomplete.tsx 93.61% <0.00%> (+4.25%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2eb79ef...87bee39. Read the comment docs.

@cmdcolin
Copy link
Collaborator Author

The disableClickEventBubbling appeared to not be enabled in the data-grid typescript yet (asked in linked issue about this) but to fix temporarily had to add a crazy ts-ignore + prettier-ignore (can't ts-ignore just a single jsx attribute, so have to prettier-ignore to make it go to a single line and then ts-ignore that line)

@cmdcolin cmdcolin changed the title Miscellaneous data grid improvements in feature details widget Improve copy+paste in the data grids for feature details Mar 25, 2021
@cmdcolin cmdcolin merged commit 0bc6b45 into main Mar 25, 2021
@cmdcolin cmdcolin deleted the misc_datagrid_improvements branch March 25, 2021 04:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants