Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let React LGV navigate without setting displayedRegion first #1822

Merged
merged 1 commit into from
Mar 31, 2021

Conversation

garrettjstevens
Copy link
Collaborator

Since navToLocString takes an optional assemblyName parameter now, we can avoid having to set a displayedRegion before navigating.

A similar thing could also possible be used in #1798.

@codecov
Copy link

codecov bot commented Mar 19, 2021

Codecov Report

Merging #1822 (dfc2438) into master (e2594e3) will increase coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1822   +/-   ##
=======================================
  Coverage   58.85%   58.85%           
=======================================
  Files         459      459           
  Lines       21389    21385    -4     
  Branches     5051     5048    -3     
=======================================
- Hits        12589    12587    -2     
+ Misses       8489     8487    -2     
  Partials      311      311           
Impacted Files Coverage Δ
...se-react-linear-genome-view/src/createViewState.ts 50.00% <0.00%> (+7.14%) ⬆️
...inearGenomeView/components/RefNameAutocomplete.tsx 89.36% <0.00%> (-4.26%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e2594e3...dfc2438. Read the comment docs.

Base automatically changed from master to main March 23, 2021 17:21
@rbuels
Copy link
Contributor

rbuels commented Mar 25, 2021

any reason this is still a draft? seems straightforward

@garrettjstevens garrettjstevens marked this pull request as ready for review March 25, 2021 19:35
@garrettjstevens
Copy link
Collaborator Author

marked ready for review

Copy link
Contributor

@teresam856 teresam856 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rbuels rbuels merged commit 736fa0a into main Mar 31, 2021
@rbuels rbuels deleted the react_lgv_nav branch March 31, 2021 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants