Check for existence of window more robustly to allow in SSR or node applications

[elliothershberg]

This is a tiny PR takes some of the logic out of #1125 that changes how window is used. This is to help with running JB2 in other contexts than the browser, where window might not be defined.

This is related to #1786 . I'm looking into how our React LGV works inside of a vanilla Next.js app, and have run into issues with window not being defined.

[rbuels]

seems pretty straightforward, any reason this is still a draft?

[elliothershberg]

seems pretty straightforward, any reason this is still a draft?

Was just checking to make sure it removed all lines causing the error I was seeing. Yeah, should be good to go.

[codecov]

Codecov Report

Merging #1811 (090942b) into master (cf315fb) will decrease coverage by 0.01%.
The diff coverage is 72.72%.

@@            Coverage Diff             @@
##           master    #1811      +/-   ##
==========================================
- Coverage   58.60%   58.58%   -0.02%     
==========================================
  Files         459      459              
  Lines       21296    21298       +2     
  Branches     5022     5027       +5     
==========================================
- Hits        12481    12478       -3     
- Misses       8505     8510       +5     
  Partials      310      310              

Impacted Files	Coverage Δ
packages/core/util/index.ts	80.99% <40.00%> (-0.83%)	⬇️
packages/core/rpc/BaseRpcDriver.ts	93.75% <100.00%> (ø)
packages/core/rpc/ElectronRpcDriver.ts	3.50% <100.00%> (+1.72%)	⬆️
packages/core/util/calculateStaticBlocks.ts	100.00% <100.00%> (ø)
packages/core/util/io/ElectronLocalFile.ts	3.70% <100.00%> (ø)
packages/core/util/io/ElectronRemoteFile.ts	0.94% <100.00%> (ø)
...inearGenomeView/components/RefNameAutocomplete.tsx	89.36% <0.00%> (-4.26%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf315fb...090942b. Read the comment docs.