Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pileup sorting when using string tag #1750

Merged
merged 1 commit into from
Mar 1, 2021
Merged

Conversation

cmdcolin
Copy link
Collaborator

Currently if someone tries to sort based on a string tag, it fails to sort

This tries to determine upfront whether a tag is of type string (looks at first element)

Then it sorts using localeCompare to sort the strings

@github-actions github-actions bot added the needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) label Feb 28, 2021
@cmdcolin cmdcolin added bug Something isn't working and removed needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) labels Feb 28, 2021
@codecov
Copy link

codecov bot commented Feb 28, 2021

Codecov Report

Merging #1750 (7a65746) into master (d5d643b) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1750      +/-   ##
==========================================
- Coverage   58.81%   58.80%   -0.02%     
==========================================
  Files         454      454              
  Lines       21001    21005       +4     
  Branches     4974     4974              
==========================================
  Hits        12351    12351              
- Misses       8340     8344       +4     
  Partials      310      310              
Impacted Files Coverage Δ
plugins/alignments/src/PileupRenderer/sortUtil.ts 36.20% <0.00%> (-2.69%) ⬇️
packages/core/util/index.ts 82.52% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d5d643b...7a65746. Read the comment docs.

@cmdcolin cmdcolin merged commit d59bbfa into master Mar 1, 2021
@cmdcolin cmdcolin deleted the fix_sort_string branch March 1, 2021 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant