Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to display crosshatches on the wiggle line/xyplot renderer #1742

Merged
merged 3 commits into from
Feb 26, 2021

Conversation

cmdcolin
Copy link
Collaborator

Adds a setting to display crosshatches, editable via the track menu for wiggle tracks. Moves the "ticks" concept into the model so the renderer can use the ticks

localhost_3000__config=test_data%2Fvolvox%2Fconfig json session=local-4zNuYPPf-

@github-actions github-actions bot added the needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) label Feb 25, 2021
@cmdcolin cmdcolin added enhancement New feature or request and removed needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) labels Feb 25, 2021
@cmdcolin cmdcolin force-pushed the display_cross_hatches branch from ec9170e to b701ef7 Compare February 25, 2021 08:22
@codecov
Copy link

codecov bot commented Feb 25, 2021

Codecov Report

Merging #1742 (8f8dc8e) into master (60ea4ca) will decrease coverage by 0.03%.
The diff coverage is 53.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1742      +/-   ##
==========================================
- Coverage   58.86%   58.83%   -0.04%     
==========================================
  Files         454      454              
  Lines       20966    20999      +33     
  Branches     4968     4974       +6     
==========================================
+ Hits        12341    12354      +13     
- Misses       8315     8335      +20     
  Partials      310      310              
Impacted Files Coverage Δ
...nts/src/SNPCoverageRenderer/SNPCoverageRenderer.ts 100.00% <ø> (ø)
plugins/wiggle/src/WiggleBaseRenderer.ts 100.00% <ø> (ø)
...ns/wiggle/src/LinePlotRenderer/LinePlotRenderer.js 68.62% <22.22%> (-9.95%) ⬇️
...lugins/wiggle/src/XYPlotRenderer/XYPlotRenderer.ts 65.82% <22.22%> (-5.61%) ⬇️
...ins/wiggle/src/LinearWiggleDisplay/models/model.ts 71.49% <63.15%> (-0.99%) ⬇️
...iggleDisplay/components/WiggleDisplayComponent.tsx 100.00% <100.00%> (ø)
packages/core/util/index.ts 82.52% <0.00%> (+0.32%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 60ea4ca...8f8dc8e. Read the comment docs.

@cmdcolin cmdcolin merged commit 49862a1 into master Feb 26, 2021
@cmdcolin cmdcolin deleted the display_cross_hatches branch February 26, 2021 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant