Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instrument navToLocString tests in the LGV and fix refname navigation #1741

Merged
merged 1 commit into from
Feb 24, 2021

Conversation

cmdcolin
Copy link
Collaborator

This tries to instrument some simple navToLocString tests for the LGV for easier testing of corner cases

There is likely more that can be done to ensure reliability but I hope these tests could be a starting point for simulating end-user behavior of using locstring inputs

Fixes #1740

@github-actions github-actions bot added the needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) label Feb 24, 2021
@codecov
Copy link

codecov bot commented Feb 24, 2021

Codecov Report

Merging #1741 (40b4b53) into master (d4bd417) will decrease coverage by 0.00%.
The diff coverage is 88.88%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1741      +/-   ##
==========================================
- Coverage   58.83%   58.83%   -0.01%     
==========================================
  Files         450      450              
  Lines       20845    20848       +3     
  Branches     4941     4942       +1     
==========================================
+ Hits        12265    12266       +1     
- Misses       8272     8274       +2     
  Partials      308      308              
Impacted Files Coverage Δ
...s/linear-genome-view/src/LinearGenomeView/index.ts 84.04% <88.88%> (+0.26%) ⬆️
...inearGenomeView/components/RefNameAutocomplete.tsx 89.36% <0.00%> (-4.26%) ⬇️
packages/core/util/index.ts 82.20% <0.00%> (-0.33%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d4bd417...40b4b53. Read the comment docs.

@cmdcolin cmdcolin removed the needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) label Feb 24, 2021
@rbuels rbuels merged commit a38e741 into master Feb 24, 2021
@rbuels rbuels deleted the fix_locstring_nav branch February 24, 2021 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using locstring navigation with refName navigates to very start of chromosome
2 participants