Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix alignment track ability to remember the height of the SNPCoverage subtrack on refresh #1731

Merged
merged 1 commit into from
Feb 24, 2021

Conversation

cmdcolin
Copy link
Collaborator

Currently changing the snpcov subtrack height is not remembered on refresh

This fixes that. There is an old useEffect thing that was hacky that was causing reset to height:45 along with a couple other things

The autorun that propagates state from alignments display model to the SNPCoverage display model is kind of awkward and could be evaluated, but this fixes the particular issue of setting the subtrack height in track state

@github-actions github-actions bot added the needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) label Feb 23, 2021
@codecov
Copy link

codecov bot commented Feb 23, 2021

Codecov Report

Merging #1731 (8040f7f) into master (720894f) will increase coverage by 0.01%.
The diff coverage is 57.14%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1731      +/-   ##
==========================================
+ Coverage   58.83%   58.84%   +0.01%     
==========================================
  Files         450      450              
  Lines       20845    20851       +6     
  Branches     4941     4940       -1     
==========================================
+ Hits        12264    12270       +6     
  Misses       8273     8273              
  Partials      308      308              
Impacted Files Coverage Δ
plugins/alignments/src/CramAdapter/CramAdapter.ts 82.56% <0.00%> (ø)
...AlignmentsDisplay/components/AlignmentsDisplay.tsx 43.75% <ø> (-6.25%) ⬇️
...nments/src/LinearAlignmentsDisplay/models/model.ts 67.60% <60.00%> (+4.11%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 720894f...8040f7f. Read the comment docs.

@cmdcolin cmdcolin added the bug Something isn't working label Feb 23, 2021
@cmdcolin cmdcolin changed the title Add ability to remember the height of the SNPCoverage subtrack on refresh Fix alignment track ability to remember the height of the SNPCoverage subtrack on refresh Feb 23, 2021
@cmdcolin cmdcolin removed the needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) label Feb 23, 2021
@rbuels rbuels merged commit e30f5e3 into master Feb 24, 2021
@rbuels rbuels deleted the snpcov_height branch February 24, 2021 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants