Add list of loaded plugins to the "About widget" #1728
Conversation
added pluginManager.pluginMetaData that can be used to hold metadata about plugins and why and from where they were loaded. currently just holds `isCore: boolean`.
cmdcolin
force-pushed
the
about_dialog_plugin_list_rmb
branch
from
f6fbfe0 to
3621e0c
Compare
|
This is fine with me, my approach was pretty silly and I like the more generic thing here. It's a little bit unclear what other kinds of metadata can be used but just having it like this feels a bit more sane To think of an analogy in executables, this is kind of like listing dynamically loaded libraries vs statically loaded ones...kind of a useful analogy when referring to runtime plugins in general probably |
|
I added ability to link to an external link automatically if the plugin supplies it via a Plugin class attribute "url" (version from the plugin class can also be obtained this way) |
Codecov Report
@@ Coverage Diff @@
## master #1728 +/- ##
==========================================
+ Coverage 58.84% 58.90% +0.05%
==========================================
Files 449 449
Lines 20777 20804 +27
Branches 4923 4930 +7
==========================================
+ Hits 12227 12255 +28
+ Misses 8243 8242 -1
Partials 307 307
Continue to review full report at Codecov.
|
|
i figure down the road we might possibly use this mechanism to track "why" we have a plugin loaded, if we do inter-plugin dependencies, or if the plugin was loaded from a session |
Slightly tweaked approach to #1715. Instead of making the plugin manager know that some plugins are "core" and others are not, adds a more general plugin metadata area (optional) that can hold anything, and has the about widget and the jbrowse-web loader set an
isCoreboolean in that.