-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Standardize phred qual scaling between BAM and CRAM and add option to make mismatches render in a lighter color when quality is low #1720
Conversation
9ae8113
to
97172f7
Compare
Codecov Report
@@ Coverage Diff @@
## master #1720 +/- ##
==========================================
+ Coverage 58.81% 58.83% +0.01%
==========================================
Files 448 448
Lines 20754 20767 +13
Branches 4919 4922 +3
==========================================
+ Hits 12207 12218 +11
- Misses 8240 8242 +2
Partials 307 307
Continue to review full report at Codecov.
|
504f868
to
d68a37e
Compare
but does this lead to the quality scores being all -33 in the feature details panel? |
Nope, the scores are reported as numbers in the range 0-93 or so when you add 33, you get it starting in the ascii range 33, the first printable character !, to 126, a ~ last printable http://www.asciitable.com/ So the only reason to add 33 is so that you can encode them into an ascii string And with this change the "Color by per-base quality" and the feature detail panel qual score reports are the same for a BAM and CRAM file. Can see this in volvox examples (many tracks have both BAM and CRAM examples) and the human data (HG002 ultralong BAM and CRAM exist) |
This adds
(a) a new coloring option "Adjust mismatch visibility by quality" that helps adjust the coloring of SNPs by their qual score
(b) standardize the qual score across BAM and CRAM. the CRAM was adding +33 which is basically what is done to report proper ASCII characters for scores, but to be standardized we skip adding +33