Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable copy/delete menu items for reference sequence track #1689

Merged
merged 3 commits into from
Feb 12, 2021

Conversation

teresam856
Copy link
Contributor

@teresam856 teresam856 commented Feb 11, 2021

Issue 1459
In this PR:

  • disables the copy/delete menu items for the reference sequence track
  • adds a check in trackConfigurations to verify that trackConfAssemblies is not undefined before checking if it includes an assembly name was already resolved on master branch
  • adds test

@teresam856 teresam856 added the bug Something isn't working label Feb 11, 2021
@teresam856 teresam856 self-assigned this Feb 11, 2021
@teresam856 teresam856 marked this pull request as draft February 11, 2021 19:15
@teresam856 teresam856 changed the title disable copy track in refseq track disable menu items for reference sequence track Feb 11, 2021
@codecov
Copy link

codecov bot commented Feb 11, 2021

Codecov Report

Merging #1689 (3ff2468) into master (16a142d) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1689      +/-   ##
==========================================
- Coverage   58.96%   58.95%   -0.01%     
==========================================
  Files         446      446              
  Lines       20434    20436       +2     
  Branches     4812     4814       +2     
==========================================
  Hits        12048    12048              
+ Misses       8091     8090       -1     
- Partials      295      298       +3     
Impacted Files Coverage Δ
products/jbrowse-web/src/sessionModelFactory.ts 63.01% <100.00%> (+0.25%) ⬆️
...inearGenomeView/components/RefNameAutocomplete.tsx 89.36% <0.00%> (-4.26%) ⬇️
products/jbrowse-desktop/src/factoryReset.ts 0.00% <0.00%> (ø)
...y-jbrowse/src/JBrowse1Connection/jb1ConfigParse.ts 25.88% <0.00%> (ø)
...src/LinearPileupDisplay/components/FilterByTag.tsx 5.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 16a142d...3ff2468. Read the comment docs.

@rbuels rbuels marked this pull request as ready for review February 12, 2021 19:38
@rbuels rbuels linked an issue Feb 12, 2021 that may be closed by this pull request
@rbuels rbuels merged commit 1e34b76 into master Feb 12, 2021
@rbuels rbuels deleted the 1459_refseqtrack branch February 12, 2021 19:49
@cmdcolin cmdcolin changed the title disable menu items for reference sequence track Disable copy/delete menu items for reference sequence track Feb 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Attempting to copy the reference sequence track produces an error
2 participants