Fix issue with using launching the add track widget on views that are not displaying any regions #1679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bly is defined, small addition to test
…onidtional for adding widget
github-actions
bot
added
the
needs label triage
teresam856
added
bug
Codecov Report
@@ Coverage Diff @@
## master #1679 +/- ##
==========================================
+ Coverage 58.89% 58.93% +0.03%
==========================================
Files 446 446
Lines 20424 20427 +3
Branches 4803 4806 +3
==========================================
+ Hits 12029 12038 +9
+ Misses 8098 8092 -6
Partials 297 297
Continue to review full report at Codecov.
|
cmdcolin
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative Proposal to pull request 1676 to fix bug 1674
Jbrowse web currently crashes when we click File -> Open Track while an import form is being rendered due to
This PR
Adds error handling when retrieving assemblyName from displayedRegions in the addTrackWidget model.ts. Not all views have displayedRegions @ session.views[0] (e.g synteny which has them @ session.views[0].views) which causes 'TypeError: Cannot read property 'assemblyName' of undefined'. DisplayedRegions can also be undefined when opening a view (import form) but displayedRegions are still yet to be defined which will throw the same error.
Small test in CircularView. Tests being able to click
Open Trackfrom circular view set up wizard without crashing Jbrowse web.